[PR #47] [MERGED] fix(gc): spare support containers owned by a running managed container #49

New issue

Closed

opened 2026-10-15 12:51:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/47
Author: @JBailes
Created: 6/4/2026
Status: ✅ Merged
Merged: 6/4/2026
Merged by: @JBailes

Base: docker-lxc-daemon ← Head: fix/gc-spare-managed-owner-support-containers

📝 Commits (1)

1d4a508 fix(gc): spare support containers owned by a running managed container

📊 Changes

1 file changed (+21 additions, -11 deletions)

View changed files

📝 internal/lxc/manager.go (+21 -11)

📄 Description

The GC orphan reaper only spared support containers when a Proxmox CT (VMID>0) was running. When the owner runs as a managed LXC2Docker container
(io.smoothnas.managed=true, VMID=0) — e.g. Wolf — the WolfPulseAudio it spawns at boot is reaped a GC cycle later while the owner is still running and
idle, killing Wolf's audio and crash-looping it. Generalize the guard to also treat a running managed container as an owner (that label already exempts the
owner itself from GC).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/47 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 6/4/2026 **Status:** ✅ Merged **Merged:** 6/4/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `docker-lxc-daemon` ← **Head:** `fix/gc-spare-managed-owner-support-containers` --- ### 📝 Commits (1) - [`1d4a508`](https://github.com/games-on-whales/LXC2Docker/commit/1d4a508f1d8d2a02886316b5662ab0459dfc8dc8) fix(gc): spare support containers owned by a running managed container ### 📊 Changes **1 file changed** (+21 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `internal/lxc/manager.go` (+21 -11) </details> ### 📄 Description The GC orphan reaper only spared support containers when a Proxmox CT (VMID>0) was running. When the owner runs as a managed LXC2Docker container (io.smoothnas.managed=true, VMID=0) — e.g. Wolf — the WolfPulseAudio it spawns at boot is reaped a GC cycle later while the owner is still running and idle, killing Wolf's audio and crash-looping it. Generalize the guard to also treat a running managed container as an owner (that label already exempts the owner itself from GC). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:37 +00:00