mirror of
https://github.com/games-on-whales/gow.git
synced 2026-10-15 21:02:02 +00:00
[PR #69] [MERGED] refactor compose files to (hopefully) make it easier to pick and choose containers #131
Labels
No labels
bug
enhancement
enhancement
github_actions
good first issue
help wanted
help wanted
invalid
needs testers
pull-request
question
x11-images
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
games-on-whales/gow#131
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/games-on-whales/gow/pull/69
Author: @zb140
Created: 7/30/2022
Status: ✅ Merged
Merged: 9/3/2022
Merged by: @zb140
Base:
master← Head:zb140/refactor-compose-files📝 Commits (10+)
a21ddadrefactor compose files to (hopefully) make it easier to pick and choose containers5d3db02add a launch script3e2c96dpass extra args from run-gow to docker-compose; fix typof9369eeFix for docker-compose > v2.6.0058358efix default local_state locationf796858add location of nvidia drivers on Arch042203bsome run-gow updates: add comments, refactor for readability, add --env-file option, check for a compatible docker-compose version. update docs to refer to run-gow instead of docker-compose directly.61c5163Address testing feedback88ca7f7need the udev container in host-desktop mode too; add a host-desktop.yml; update docs3c189cfforgot a file📊 Changes
28 files changed (+789 additions, -571 deletions)
View changed files
➖
.env(+0 -47)📝
README.md(+12 -4)➕
compose/firefox.yml(+24 -0)➕
compose/headless.yml(+77 -0)➕
compose/host-dekstop.yml(+2 -0)➕
compose/retroarch.yml(+47 -0)➕
compose/steam.yml(+46 -0)➕
config/common.env(+1 -0)➕
config/intel.env(+3 -0)➕
config/nvidia.env(+2 -0)➕
config/xorg.env(+2 -0)📝
docker-compose.yml(+24 -179)📝
docs/modules/ROOT/pages/components-overview.adoc(+1 -2)📝
docs/modules/ROOT/pages/debian-desktop.adoc(+34 -182)📝
docs/modules/ROOT/pages/debian-headless.adoc(+21 -7)📝
docs/modules/ROOT/pages/desktop.adoc(+0 -3)📝
docs/modules/ROOT/pages/docker-build.adoc(+3 -1)📝
docs/modules/ROOT/pages/headless-unraid.adoc(+24 -27)📝
docs/modules/ROOT/pages/how-to-use.adoc(+11 -31)📝
docs/modules/ROOT/pages/kubernetes.adoc(+1 -1)...and 8 more files
📄 Description
There's sort of two "modes" we can run in: "headless" (ie, run Xorg containerized), and "host" (ie, use the Xorg running on the host). With just a single
docker-compose.ymlfile, we have to choose which one of those is going to be the checked-in version, and anyone who wants to run the other will have to make manual modifications to the file.This is a proposal for a method of making that easier. I've split the configuration into several files. Now there's:
docker-compose.ymlthat just launches a containerized Sunshinecompose/headless.yml, which addsxorg,udevd, andpulse, for systems that don't have those alreadycompose/steam.yml,compose/retroarch.yml, andcompose/firefox.yml, which add those respective applicationsI've also added some files in the
envsubdirectory; these allow adding the same set of environment variables to multiple containers without a bunch of error-prone copy and paste.I've tested this pretty well on my unRAID server and things seem to be going well, but I don't have a host to try on that already has Xorg etc, so that could use some testing.
What do you think?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.