[PR #86] [MERGED] Add an action to lint shell scripts and Dockerfiles #141

New issue

Closed

opened 2026-10-15 12:49:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:49:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gow/pull/86
Author: @zb140
Created: 9/18/2022
Status: ✅ Merged
Merged: 10/15/2022
Merged by: @zb140

Base: master ← Head: zb140/shellcheck

📝 Commits (5)

37fcf62 add an action to run linters on shell scripts and Dockerfiles
c71ca63 Add yaml and env linters
516fd0e specify which files to lint
3098f3c fix some lint issues
607c0df more lint fixes

📊 Changes

12 files changed (+88 additions, -22 deletions)

View changed files

➕ .github/workflows/lint.yml (+40 -0)
📝 images/base-app/Dockerfile (+2 -0)
📝 images/base/build/setup-retro-user (+15 -11)
📝 images/base/scripts/bootstrap.sh (+4 -1)
📝 images/base/scripts/lib/utils.sh (+2 -0)
📝 images/pulseaudio/Dockerfile (+2 -0)
📝 images/retroarch/Dockerfile (+3 -1)
📝 images/steam/Dockerfile (+2 -0)
📝 images/sunshine/Dockerfile (+6 -3)
📝 images/udevd/Dockerfile (+2 -0)
📝 images/xorg/Dockerfile (+2 -0)
📝 images/xorg/scripts/ensure-nvidia-xorg-driver.sh (+8 -6)

📄 Description

Added an action to run linters for shell scripts and Dockerfiles. It will run on any PR. If there's a lint issue in one of the files being modified, it will add a review pointing out the specific line and error. If it finds errors in files not in the PR, those will get noted under the "Checks" tab. None of this blocks merging the PR anyway, but it should make it much easier to spot potential problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gow/pull/86 **Author:** [@zb140](https://github.com/zb140) **Created:** 9/18/2022 **Status:** ✅ Merged **Merged:** 10/15/2022 **Merged by:** [@zb140](https://github.com/zb140) **Base:** `master` ← **Head:** `zb140/shellcheck` --- ### 📝 Commits (5) - [`37fcf62`](https://github.com/games-on-whales/gow/commit/37fcf62be4bdbda5cbce32dad67d4929bef0672f) add an action to run linters on shell scripts and Dockerfiles - [`c71ca63`](https://github.com/games-on-whales/gow/commit/c71ca636dc43985c80b52ff425b76587c377f164) Add yaml and env linters - [`516fd0e`](https://github.com/games-on-whales/gow/commit/516fd0ec75109b5e74485662810996ad54e80acf) specify which files to lint - [`3098f3c`](https://github.com/games-on-whales/gow/commit/3098f3c0f2cf9adee2fa12df199dcf6bb1e64b38) fix some lint issues - [`607c0df`](https://github.com/games-on-whales/gow/commit/607c0dfda0977eaf08587ce50096d2205d2cc695) more lint fixes ### 📊 Changes **12 files changed** (+88 additions, -22 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/lint.yml` (+40 -0) 📝 `images/base-app/Dockerfile` (+2 -0) 📝 `images/base/build/setup-retro-user` (+15 -11) 📝 `images/base/scripts/bootstrap.sh` (+4 -1) 📝 `images/base/scripts/lib/utils.sh` (+2 -0) 📝 `images/pulseaudio/Dockerfile` (+2 -0) 📝 `images/retroarch/Dockerfile` (+3 -1) 📝 `images/steam/Dockerfile` (+2 -0) 📝 `images/sunshine/Dockerfile` (+6 -3) 📝 `images/udevd/Dockerfile` (+2 -0) 📝 `images/xorg/Dockerfile` (+2 -0) 📝 `images/xorg/scripts/ensure-nvidia-xorg-driver.sh` (+8 -6) </details> ### 📄 Description Added an action to run linters for shell scripts and Dockerfiles. It will run on any PR. If there's a lint issue in one of the files being modified, it will add a review pointing out the specific line and error. If it finds errors in files _not_ in the PR, those will get noted under the "Checks" tab. None of this blocks merging the PR anyway, but it should make it much easier to spot potential problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:49:25 +00:00