[PR #316] [MERGED] xfce: fix Fedora dnf install and wire Flathub into gnome-software #299

New issue

Closed

opened 2026-10-15 12:50:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:50:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gow/pull/316
Author: @JBailes
Created: 4/18/2026
Status: ✅ Merged
Merged: 4/18/2026
Merged by: @JBailes

Base: fedora-variant-images ← Head: fix/xfce-fedora-flatpak

📝 Commits (1)

856fccc xfce: fix Fedora dnf install and wire up Flathub for gnome-software

📊 Changes

1 file changed (+34 additions, -23 deletions)

View changed files

📝 apps/xfce/build-fedora/Dockerfile (+34 -23)

📄 Description

Summary

Fixes two real problems with the Fedora XFCE image on #305:

The dnf install block in apps/xfce/build-fedora/Dockerfile used inline # comment \ lines between continued arguments. Bash treats the # as a comment that consumes the trailing backslash, so the continuation breaks and most of the package list runs as separate (failing) commands. Collapsed the comments out of the continuation so the full list reaches dnf.
gnome-software didn't pick up Flathub and defaulted to dnf installs. Registered Flathub as a system remote, pre-seeded its AppStream metadata at build time (without this flathub apps don't appear in the Software UI on first launch), and dropped a dconf override setting packaging-format-preference=['flatpak', 'rpm'] so gnome-software prefers flatpak when both backends offer the same app.

Also pulls in dconf explicitly so the override compiles during build.

Test plan

CI builds xfce:fedora (auto-build.yml Fedora chain) successfully
Launch the XFCE Fedora app in Wolf; open "Software" and confirm Flathub apps are listed
Install an app from Software and confirm it lands as a flatpak (e.g. in /var/lib/flatpak/app/...), not a dnf package
flatpak remote-list --system shows flathub in the running container

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gow/pull/316 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/18/2026 **Status:** ✅ Merged **Merged:** 4/18/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `fedora-variant-images` ← **Head:** `fix/xfce-fedora-flatpak` --- ### 📝 Commits (1) - [`856fccc`](https://github.com/games-on-whales/gow/commit/856fccc0ec0ca6137f696dc60fa745a883f3dbf0) xfce: fix Fedora dnf install and wire up Flathub for gnome-software ### 📊 Changes **1 file changed** (+34 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `apps/xfce/build-fedora/Dockerfile` (+34 -23) </details> ### 📄 Description ## Summary Fixes two real problems with the Fedora XFCE image on #305: - The `dnf install` block in `apps/xfce/build-fedora/Dockerfile` used inline `# comment \` lines between continued arguments. Bash treats the `#` as a comment that consumes the trailing backslash, so the continuation breaks and most of the package list runs as separate (failing) commands. Collapsed the comments out of the continuation so the full list reaches `dnf`. - gnome-software didn't pick up Flathub and defaulted to dnf installs. Registered Flathub as a **system** remote, pre-seeded its AppStream metadata at build time (without this flathub apps don't appear in the Software UI on first launch), and dropped a dconf override setting `packaging-format-preference=['flatpak', 'rpm']` so gnome-software prefers flatpak when both backends offer the same app. Also pulls in `dconf` explicitly so the override compiles during build. ## Test plan - [ ] CI builds `xfce:fedora` (`auto-build.yml` Fedora chain) successfully - [ ] Launch the XFCE Fedora app in Wolf; open "Software" and confirm Flathub apps are listed - [ ] Install an app from Software and confirm it lands as a flatpak (e.g. in `/var/lib/flatpak/app/...`), not a dnf package - [ ] `flatpak remote-list --system` shows `flathub` in the running container --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:50:39 +00:00