steam #309

New issue

Closed

opened 2026-10-15 12:50:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:50:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gow/pull/327
Author: @JBailes
Created: 4/30/2026
Status: ✅ Merged
Merged: 5/1/2026
Merged by: @ABeltramo

Base: master ← Head: fix/steam-fedora-preserve-legacy

📝 Commits (3)

7009b9c steam-fedora: drop auto-migration of legacy ~/.steam/steam
0feab18 steam: bake Decky Loader at build time
b409b5a Merge pull request #328 from games-on-whales/fix/steam-bake-decky-loader

📊 Changes

4 files changed (+62 additions, -24 deletions)

View changed files

📝 apps/steam/build-fedora/Dockerfile (+12 -0)
📝 apps/steam/build-fedora/scripts/system-services.sh (+31 -20)
📝 apps/steam/build/Dockerfile (+12 -0)
📝 apps/steam/build/scripts/system-services.sh (+7 -4)

📄 Description

Summary

Follow-up to #324. Every variant of the legacy ~/.steam/steam → ~/.local/share/Steam auto-migration in system-services.sh has been wrong:

The original rm -rf $STEAMDIR; mv $STEAMDIR_LEGACY $STEAMDIR looped on every restart and wiped login state (the bug #324 fixed).
The cp -aT replacement in #324 assumes ~/.local/share/Steam has enough free space for the entire library. That's false when ~/.steam is bind-mounted from a separate large drive (a common setup for users with big libraries) while $HOME sits on the small root filesystem — flagged on Discord by a user whose /home/retro/.local cannot hold the library.
Any data move risks destroying a user's library if it fails partway through.

True Ubuntu→Fedora migrations are rare enough to handle by hand. This PR removes the migration and replaces it with a clear log message describing what to do. Steam still launches — steam.sh's symlink logic already refuses to clobber a real legacy directory and prints its own warning, so we're not making any user worse off than before.

Test plan

Fresh Fedora profile (no ~/.steam): launches, ~/.steam/steam is a symlink, no warning logged.
Already-migrated profile (~/.steam/steam is a symlink): no warning logged, behavior unchanged.
Simulated Ubuntu legacy (~/.steam/steam/steamapps/<game> real dir): warning is logged with manual-migration instructions; nothing under ~/.steam is touched; Steam launches with empty library.
~/.steam bind-mounted from a separate drive: warning is logged; mount and contents are untouched; user can follow the instructions or restructure their bind mount.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gow/pull/327 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/30/2026 **Status:** ✅ Merged **Merged:** 5/1/2026 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `master` ← **Head:** `fix/steam-fedora-preserve-legacy` --- ### 📝 Commits (3) - [`7009b9c`](https://github.com/games-on-whales/gow/commit/7009b9ced04e0eaf606600bb16f76e93087fc946) steam-fedora: drop auto-migration of legacy ~/.steam/steam - [`0feab18`](https://github.com/games-on-whales/gow/commit/0feab18db7be018953085b42925c6badb02b5bcc) steam: bake Decky Loader at build time - [`b409b5a`](https://github.com/games-on-whales/gow/commit/b409b5a41047f6cd0e3021a45a66958eaabf0d78) Merge pull request #328 from games-on-whales/fix/steam-bake-decky-loader ### 📊 Changes **4 files changed** (+62 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `apps/steam/build-fedora/Dockerfile` (+12 -0) 📝 `apps/steam/build-fedora/scripts/system-services.sh` (+31 -20) 📝 `apps/steam/build/Dockerfile` (+12 -0) 📝 `apps/steam/build/scripts/system-services.sh` (+7 -4) </details> ### 📄 Description ## Summary Follow-up to #324. Every variant of the legacy `~/.steam/steam` → `~/.local/share/Steam` auto-migration in `system-services.sh` has been wrong: - The original `rm -rf $STEAMDIR; mv $STEAMDIR_LEGACY $STEAMDIR` looped on every restart and wiped login state (the bug #324 fixed). - The `cp -aT` replacement in #324 assumes `~/.local/share/Steam` has enough free space for the entire library. That's false when `~/.steam` is bind-mounted from a separate large drive (a common setup for users with big libraries) while `$HOME` sits on the small root filesystem — flagged on Discord by a user whose `/home/retro/.local` cannot hold the library. - Any data move risks destroying a user's library if it fails partway through. True Ubuntu→Fedora migrations are rare enough to handle by hand. This PR removes the migration and replaces it with a clear log message describing what to do. Steam still launches — `steam.sh`'s symlink logic already refuses to clobber a real legacy directory and prints its own warning, so we're not making any user worse off than before. ## Test plan - [ ] Fresh Fedora profile (no `~/.steam`): launches, `~/.steam/steam` is a symlink, no warning logged. - [ ] Already-migrated profile (`~/.steam/steam` is a symlink): no warning logged, behavior unchanged. - [ ] Simulated Ubuntu legacy (`~/.steam/steam/steamapps/<game>` real dir): warning is logged with manual-migration instructions; nothing under `~/.steam` is touched; Steam launches with empty library. - [ ] `~/.steam` bind-mounted from a separate drive: warning is logged; mount and contents are untouched; user can follow the instructions or restructure their bind mount. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:50:44 +00:00