[PR #13] [MERGED] Update smithay and rust to latest release #18

New issue

Closed

opened 2026-10-15 12:47:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:47:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gst-wayland-display/pull/13
Author: @DatCaptainHorse
Created: 7/21/2025
Status: ✅ Merged
Merged: 7/29/2025
Merged by: @ABeltramo

Base: stable ← Head: feat/update-smithay

📝 Commits (10+)

97929e0 Update smithay to latest release
22907a4 fmt: fixed formatting and added Github action for automate it
df894fd feat: refactor State creation so that we can re-use it in tests
a6894a5 feat: implemented basic tests for inputs
91c48fa fix: keyboard scancode to keycode conversion
099615e fix: mouse movements and constraints
10ae3d2 fix: move back upstream Smithay to our fork
bec45f6 tests: add test for coords clamping
1a8703c tests: added basic Wayland client for proper integration tests
d84b0c8 tests: Wayland client - added lock_pointer

📊 Changes

27 files changed (+2819 additions, -779 deletions)

View changed files

➕ .github/workflows/rust-format.yml (+19 -0)
📝 Cargo.lock (+812 -348)
📝 c-bindings/src/capi.rs (+14 -5)
📝 gst-plugin-wayland-display/Cargo.toml (+2 -2)
📝 gst-plugin-wayland-display/src/waylandsrc/imp.rs (+18 -9)
📝 wayland-display-core/Cargo.toml (+11 -6)
📝 wayland-display-core/src/comp/focus.rs (+192 -79)
📝 wayland-display-core/src/comp/input.rs (+284 -111)
📝 wayland-display-core/src/comp/mod.rs (+155 -128)
📝 wayland-display-core/src/comp/rendering.rs (+14 -11)
📝 wayland-display-core/src/lib.rs (+12 -6)
➕ wayland-display-core/src/tests/client.rs (+566 -0)
➕ wayland-display-core/src/tests/fixture.rs (+176 -0)
➕ wayland-display-core/src/tests/mod.rs (+3 -0)
➕ wayland-display-core/src/tests/test_pointer.rs (+291 -0)
📝 wayland-display-core/src/utils/allocator/mod.rs (+163 -31)
📝 wayland-display-core/src/utils/mod.rs (+1 -1)
📝 wayland-display-core/src/utils/target.rs (+3 -5)
📝 wayland-display-core/src/wayland/handlers/compositor.rs (+9 -5)
📝 wayland-display-core/src/wayland/handlers/data_device.rs (+4 -2)

...and 7 more files

📄 Description

Rough update to latest Smithay, does not take advantage of new changes, just made it "compatible".

Marking as draft as there's some oddities I noticed when updating (using smithay's example code as reference), like pointer_motion_absolute doing relative mouse update, along other things which seemed odd logically so I removed them for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gst-wayland-display/pull/13 **Author:** [@DatCaptainHorse](https://github.com/DatCaptainHorse) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/29/2025 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `stable` ← **Head:** `feat/update-smithay` --- ### 📝 Commits (10+) - [`97929e0`](https://github.com/games-on-whales/gst-wayland-display/commit/97929e00ba4332b9460d9233481880f535c42f48) Update smithay to latest release - [`22907a4`](https://github.com/games-on-whales/gst-wayland-display/commit/22907a496eb9d79d90866afe695abc694f9aeafe) fmt: fixed formatting and added Github action for automate it - [`df894fd`](https://github.com/games-on-whales/gst-wayland-display/commit/df894fda77beb831188a948406e61d156df18283) feat: refactor State creation so that we can re-use it in tests - [`a6894a5`](https://github.com/games-on-whales/gst-wayland-display/commit/a6894a5608e7bdb1bde083c46c31da6a865b7ace) feat: implemented basic tests for inputs - [`91c48fa`](https://github.com/games-on-whales/gst-wayland-display/commit/91c48fa297470f48393e0ded31b086c3c614b017) fix: keyboard scancode to keycode conversion - [`099615e`](https://github.com/games-on-whales/gst-wayland-display/commit/099615e077c7e816dee2d615a83b9eb6a31ca05c) fix: mouse movements and constraints - [`10ae3d2`](https://github.com/games-on-whales/gst-wayland-display/commit/10ae3d2d9765a2c20c1d50d3c68809ebe1456e6f) fix: move back upstream Smithay to our fork - [`bec45f6`](https://github.com/games-on-whales/gst-wayland-display/commit/bec45f63606c0f92e274c3d0c7500cc323bd308a) tests: add test for coords clamping - [`1a8703c`](https://github.com/games-on-whales/gst-wayland-display/commit/1a8703c03dc32d1580a9ea3f863a89f1cc526d1c) tests: added basic Wayland client for proper integration tests - [`d84b0c8`](https://github.com/games-on-whales/gst-wayland-display/commit/d84b0c8b5c4d053fcb4dbcb9697035a4a36b43d8) tests: Wayland client - added lock_pointer ### 📊 Changes **27 files changed** (+2819 additions, -779 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/rust-format.yml` (+19 -0) 📝 `Cargo.lock` (+812 -348) 📝 `c-bindings/src/capi.rs` (+14 -5) 📝 `gst-plugin-wayland-display/Cargo.toml` (+2 -2) 📝 `gst-plugin-wayland-display/src/waylandsrc/imp.rs` (+18 -9) 📝 `wayland-display-core/Cargo.toml` (+11 -6) 📝 `wayland-display-core/src/comp/focus.rs` (+192 -79) 📝 `wayland-display-core/src/comp/input.rs` (+284 -111) 📝 `wayland-display-core/src/comp/mod.rs` (+155 -128) 📝 `wayland-display-core/src/comp/rendering.rs` (+14 -11) 📝 `wayland-display-core/src/lib.rs` (+12 -6) ➕ `wayland-display-core/src/tests/client.rs` (+566 -0) ➕ `wayland-display-core/src/tests/fixture.rs` (+176 -0) ➕ `wayland-display-core/src/tests/mod.rs` (+3 -0) ➕ `wayland-display-core/src/tests/test_pointer.rs` (+291 -0) 📝 `wayland-display-core/src/utils/allocator/mod.rs` (+163 -31) 📝 `wayland-display-core/src/utils/mod.rs` (+1 -1) 📝 `wayland-display-core/src/utils/target.rs` (+3 -5) 📝 `wayland-display-core/src/wayland/handlers/compositor.rs` (+9 -5) 📝 `wayland-display-core/src/wayland/handlers/data_device.rs` (+4 -2) _...and 7 more files_ </details> ### 📄 Description Rough update to latest Smithay, does not take advantage of new changes, just made it "compatible". Marking as draft as there's some oddities I noticed when updating (using smithay's example code as reference), like `pointer_motion_absolute` doing relative mouse update, along other things which seemed odd logically so I removed them for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:47:33 +00:00