[PR #26] [MERGED] fix: use proper function to get `VideoFormat` from fourcc #28

New issue

Closed

opened 2026-10-15 12:47:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:47:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gst-wayland-display/pull/26
Author: @mhebant
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @ABeltramo

Base: stable ← Head: stable

📝 Commits (2)

e89c1a2 fix: use proper function to get VideoFormat from fourcc
c3ee191 fmt: run cargo fmt

📊 Changes

2 files changed (+74 additions, -37 deletions)

View changed files

📝 gst-plugin-wayland-display/src/waylandsrc/imp.rs (+71 -31)
📝 wayland-display-core/src/utils/allocator/mod.rs (+3 -6)

📄 Description

Just a very small fix, as I was also struggling with this and just found a better way

VideoFormat::from_fourcc calls the c function gst_video_format_from_fourcc
which only works on YUV formats [1]
Instead use gst_video_dma_drm_fourcc_to_format which works on a wider range of formats.

[1] https://gstreamer.freedesktop.org/documentation/video/video-format.html?gi-language=c#gst_video_format_from_fourcc

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gst-wayland-display/pull/26 **Author:** [@mhebant](https://github.com/mhebant) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `stable` ← **Head:** `stable` --- ### 📝 Commits (2) - [`e89c1a2`](https://github.com/games-on-whales/gst-wayland-display/commit/e89c1a278ea11f9297d3d64a7fbb40952bb514f1) fix: use proper function to get `VideoFormat` from fourcc - [`c3ee191`](https://github.com/games-on-whales/gst-wayland-display/commit/c3ee1910a0c0ba1c073732b06b7836027cdddd76) fmt: run cargo fmt ### 📊 Changes **2 files changed** (+74 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `gst-plugin-wayland-display/src/waylandsrc/imp.rs` (+71 -31) 📝 `wayland-display-core/src/utils/allocator/mod.rs` (+3 -6) </details> ### 📄 Description Just a very small fix, as I was also struggling with this and just found a better way `VideoFormat::from_fourcc` calls the c function `gst_video_format_from_fourcc` which only works on YUV formats [1] Instead use `gst_video_dma_drm_fourcc_to_format` which works on a wider range of formats. [1] https://gstreamer.freedesktop.org/documentation/video/video-format.html?gi-language=c#gst_video_format_from_fourcc --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:47:40 +00:00