[PR #56] [MERGED] ci(vulkan-image): pin cargo-c so it stops drifting past the pinned to… #57

New issue

Closed

opened 2026-10-15 12:48:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:48:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/gst-wayland-display/pull/56
Author: @JBailes
Created: 8/16/2026
Status: ✅ Merged
Merged: 8/16/2026
Merged by: @JBailes

Base: feat/vulkan-encode ← Head: ci/pin-cargo-c

📝 Commits (1)

3f8e88e ci(vulkan-image): pin cargo-c so it stops drifting past the pinned toolchain

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 docker/vulkan.Dockerfile (+8 -1)

📄 Description

…olchain

cargo install cargo-c was unpinned while the toolchain beside it is pinned to RUST_VERSION=1.94.0, so the layer resolved whatever crates.io served that day. cargo-c 0.10.24 raised its MSRV to rustc 1.95, which turns that layer into a hard failure:

error: cannot install package `cargo-c 0.10.24+cargo-0.98.0`, it requires
rustc 1.95 or newer, while the currently active rustc version is 1.94.0

Pushes to feat/vulkan-encode kept passing because they authenticate to GHCR and reuse the cached layer. Pull-request builds skip the GHCR login, so they rebuild it from scratch and hit the wall. That is why the :vulkan job fails only on PRs, and it has now taken out #51, #52 and #55.

Reproduced and fixed on rustc 1.94.0: the unpinned command exits 101 with the error above, and --version 0.10.23 --locked exits 0 and installs cargo-cinstall, which is the binary this image actually uses.

--locked matters as much as the version: without it a transitive dependency raising its own MSRV breaks the build again even with cargo-c pinned.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/gst-wayland-display/pull/56 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 8/16/2026 **Status:** ✅ Merged **Merged:** 8/16/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `feat/vulkan-encode` ← **Head:** `ci/pin-cargo-c` --- ### 📝 Commits (1) - [`3f8e88e`](https://github.com/games-on-whales/gst-wayland-display/commit/3f8e88ec0044bb246135abd2368ce9b73b6e9891) ci(vulkan-image): pin cargo-c so it stops drifting past the pinned toolchain ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docker/vulkan.Dockerfile` (+8 -1) </details> ### 📄 Description …olchain `cargo install cargo-c` was unpinned while the toolchain beside it is pinned to `RUST_VERSION=1.94.0`, so the layer resolved whatever crates.io served that day. cargo-c 0.10.24 raised its MSRV to rustc 1.95, which turns that layer into a hard failure: error: cannot install package `cargo-c 0.10.24+cargo-0.98.0`, it requires rustc 1.95 or newer, while the currently active rustc version is 1.94.0 Pushes to feat/vulkan-encode kept passing because they authenticate to GHCR and reuse the cached layer. Pull-request builds skip the GHCR login, so they rebuild it from scratch and hit the wall. That is why the :vulkan job fails only on PRs, and it has now taken out #51, #52 and #55. Reproduced and fixed on rustc 1.94.0: the unpinned command exits 101 with the error above, and `--version 0.10.23 --locked` exits 0 and installs cargo-cinstall, which is the binary this image actually uses. `--locked` matters as much as the version: without it a transitive dependency raising its own MSRV breaks the build again even with cargo-c pinned. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-15 12:48:00 +00:00

bsakaguchi referenced this issue

2026-10-15 12:48:00 +00:00

[PR #57] [CLOSED] Chore/drop dead vulkan share #58

bsakaguchi closed this issue

2026-10-15 12:48:00 +00:00