[PR #24] [MERGED] Fix L2/R2 for DualSense controllers in some games. #31

Closed
opened 2026-10-15 12:51:27 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/inputtino/pull/24
Author: @hgaiser
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @ABeltramo

Base: stable ← Head: l2r2-pr


📝 Commits (1)

  • ac3a55d Fix L2/R2 for DualSense controllers in some games.

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 src/uhid/joypad_ps5.cpp (+13 -1)

📄 Description

Apparently the DualSense controllers send both an analogue signal as well as a digital signal. This PR modifies the set_trigger function for DS5 controllers to also send a uhid::L2 or uhid::R2 command.

This fixes an issue in at least Split Fiction, which completely seems to ignore the analogue signal and only uses the digital signal. Without this PR, that game does not recognize L2/R2 events.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/inputtino/pull/24 **Author:** [@hgaiser](https://github.com/hgaiser) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `stable` ← **Head:** `l2r2-pr` --- ### 📝 Commits (1) - [`ac3a55d`](https://github.com/games-on-whales/inputtino/commit/ac3a55df07de02160eb0d1d72eaec6cff880c50b) Fix L2/R2 for DualSense controllers in some games. ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/uhid/joypad_ps5.cpp` (+13 -1) </details> ### 📄 Description Apparently the DualSense controllers send both an analogue signal as well as a digital signal. This PR modifies the `set_trigger` function for DS5 controllers to also send a `uhid::L2` or `uhid::R2` command. This fixes an issue in at least Split Fiction, which completely seems to ignore the analogue signal and only uses the digital signal. Without this PR, that game does not recognize L2/R2 events. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 12:51:27 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/inputtino#31
No description provided.