mirror of
https://github.com/games-on-whales/inputtino.git
synced 2026-10-15 21:02:05 +00:00
[GH-ISSUE #12] Increase pen MAX_X/MAX_Y resolution #4
Labels
No labels
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
games-on-whales/inputtino#4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cfalas on GitHub (Aug 8, 2024).
Original GitHub issue: https://github.com/games-on-whales/inputtino/issues/12
When working on higher resolution displays, pen accuracy is still limited to 1920x1080, which may lead to not-very-smooth lines.
Increasing MAX_X and MAX_Y in the code should fix this https://github.com/games-on-whales/inputtino/blame/stable/src/uinput/pentablet.cpp#L24-L25.
However, I'm not sure what a reasonable value for that is - some devices support subpixel precision, much higher than the resolution of their display. I don't think there's any disadvantage of setting this to a very large value, so perhaps we could just go for 65536x65536 or something like that?
Example of 65536x65536 instead of 1920x1080:

@cfalas commented on GitHub (Aug 9, 2024):
If I understand the Android docs correctly, my tablet's digitizer has a fuzz of 0.3769x0.3769 pixels, with a
rangeof 2960x1820 (which is the display resolution), which gives a resolution of ~7854x4830.Let me know what you think a good value for the max is. Perhaps 19200x10800 might be good so that it matches the mouse config (and still looks smooth on my tablet)?
@ABeltramo commented on GitHub (Aug 9, 2024):
I can't remember where originally I took those values, from a quick scan of the Wacom driver on the Linux kernel I couldn't find anything (I think that's where I was basing my assumptions).
I can't see anything wrong with changing it, the difference in the screenshot above is night and day, so I'd be happy to take a bigger default value.