[PR #4] [MERGED] installer: offer the fedora build of the GOW app images (re-land onto main) #6

New issue

Closed

opened 2026-10-15 12:52:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:52:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/proxmox-community-script/pull/4
Author: @JBailes
Created: 8/9/2026
Status: ✅ Merged
Merged: 8/9/2026
Merged by: @JBailes

Base: main ← Head: feat/app-image-flavour-on-main

📝 Commits (1)

36a365d installer: offer the fedora build of the GOW app images

📊 Changes

4 files changed (+119 additions, -16 deletions)

View changed files

📝 .env.example (+12 -4)
📝 README.md (+13 -3)
📝 install.sh (+54 -0)
📝 tests/gather-dryrun.sh (+40 -9)

📄 Description

Re-lands the commit from #3, which never reached main.

Why this exists

#3 was stacked on fix/installer-state-volume-real-vmid with a note to retarget once #2 merged. That retarget never happened: #2 merged into main at 15:03, and #3 then merged into its now-stale base at 15:26. The result is a merge commit (a9391fb) sitting on a branch main had already absorbed — so main has the state-volume fix but not the app-image flavour prompt.

This is fcb05e7 cherry-picked onto main (39cbff8), unchanged. No conflicts.

What it does

WOLF_IMAGE_TAG was fixed at edge with no way to choose at install time, even though every app image this recipe seeds publishes a Fedora build too. The installer now asks, alongside the other settings.

Scope: apps, not Wolf

	comes from	touched here?
Wolf + Wolf Den	`WOLF_IMAGE`	no — `install.sh` never references it
`wolf-ui`	pinned `:main` in the config	no — `startup-app.sh`'s rewrite excludes it
firefox, steam, retroarch, xfce, es-de, kodi, lutris, pegasus, prismlauncher	`WOLF_IMAGE_TAG`	yes
`pulseaudio` sidecar	`WOLF_IMAGE_TAG`	yes

The choice is written to .env and shown in the install summary as Apps: ….

Tests

35 passing on the re-landed tree, plus bash -n:

tests/gather-dryrun.sh — 20 passed, 0 failed
tests/state-volume-dryrun.sh — 15 passed, 0 failed

Coverage for the flavour prompt: the fedora and edge builds are offered, a tag GHCR does not publish is rejected, a malformed tag is rejected, GHCR being unreachable does not abort the install, and the choice still installs when the reachability probe fails.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/proxmox-community-script/pull/4 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 8/9/2026 **Status:** ✅ Merged **Merged:** 8/9/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `feat/app-image-flavour-on-main` --- ### 📝 Commits (1) - [`36a365d`](https://github.com/games-on-whales/proxmox-community-script/commit/36a365d71cef7afefba534bc473a90d136c81920) installer: offer the fedora build of the GOW app images ### 📊 Changes **4 files changed** (+119 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+12 -4) 📝 `README.md` (+13 -3) 📝 `install.sh` (+54 -0) 📝 `tests/gather-dryrun.sh` (+40 -9) </details> ### 📄 Description Re-lands the commit from #3, which never reached `main`. ## Why this exists #3 was stacked on `fix/installer-state-volume-real-vmid` with a note to retarget once #2 merged. That retarget never happened: #2 merged into `main` at 15:03, and #3 then merged into its now-stale base at 15:26. The result is a merge commit (`a9391fb`) sitting on a branch `main` had already absorbed — so `main` has the state-volume fix but not the app-image flavour prompt. This is `fcb05e7` cherry-picked onto `main` (39cbff8), unchanged. No conflicts. ## What it does `WOLF_IMAGE_TAG` was fixed at `edge` with no way to choose at install time, even though every app image this recipe seeds publishes a Fedora build too. The installer now asks, alongside the other settings. ### Scope: apps, not Wolf | | comes from | touched here? | |---|---|---| | Wolf + Wolf Den | `WOLF_IMAGE` | **no** — `install.sh` never references it | | `wolf-ui` | pinned `:main` in the config | no — `startup-app.sh`'s rewrite excludes it | | firefox, steam, retroarch, xfce, es-de, kodi, lutris, pegasus, prismlauncher | `WOLF_IMAGE_TAG` | yes | | `pulseaudio` sidecar | `WOLF_IMAGE_TAG` | yes | The choice is written to `.env` and shown in the install summary as `Apps: …`. ## Tests 35 passing on the re-landed tree, plus `bash -n`: - `tests/gather-dryrun.sh` — 20 passed, 0 failed - `tests/state-volume-dryrun.sh` — 15 passed, 0 failed Coverage for the flavour prompt: the fedora and edge builds are offered, a tag GHCR does not publish is rejected, a malformed tag is rejected, GHCR being unreachable does not abort the install, and the choice still installs when the reachability probe fails. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:52:34 +00:00