[PR #20] [MERGED] Require Docker Compose at preinstall #41

New issue

Closed

opened 2026-10-15 12:55:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:55:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/unraid-plugin/pull/20
Author: @JBailes
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @JBailes

Base: wolf-plugin-rewrite ← Head: require-docker-compose

📝 Commits (1)

f645934 Require Docker Compose at preinstall and bump to 2026.04.25

📊 Changes

3 files changed (+13 additions, -2 deletions)

View changed files

📝 gow.plg (+4 -1)
📝 scripts/preinstall.sh (+8 -0)
📝 scripts/vars.sh (+1 -1)

📄 Description

Stacks on top of #18. Adds a missing dependency check.

Summary

`deploy.sh` and the Start/Stop/Update/Reconfigure actions in the settings UI all call `docker compose`, but `preinstall.sh` never verified it exists. On stock Unraid 6.12+ without the Compose Manager plugin from Community Applications, the install finishes clean and every button then fails at runtime with a cryptic 'command not found'.
Added `check_docker_compose()` that runs `docker compose version` and aborts with a clear pointer to the Compose Manager plugin, matching the existing `check_nvidia()` pattern.
Version bumped to 2026.04.25 in gow.plg and scripts/vars.sh so the release workflow picks it up on tag. 2026.04.24 was already consumed by #19 and the workflow's tag regex is strict YYYY.MM.DD.

Test plan

On an Unraid 6.12+ system without Compose Manager: install the plugin, confirm preinstall aborts with the 'install Compose Manager' message.
Install Compose Manager from CA, retry, confirm preinstall succeeds and the GoW install completes.
Tag 2026.04.25 after merge to trigger the release workflow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/unraid-plugin/pull/20 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `wolf-plugin-rewrite` ← **Head:** `require-docker-compose` --- ### 📝 Commits (1) - [`f645934`](https://github.com/games-on-whales/unraid-plugin/commit/f64593454f888f0304a07b0bf6708c64e5b8c07e) Require Docker Compose at preinstall and bump to 2026.04.25 ### 📊 Changes **3 files changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `gow.plg` (+4 -1) 📝 `scripts/preinstall.sh` (+8 -0) 📝 `scripts/vars.sh` (+1 -1) </details> ### 📄 Description Stacks on top of #18. Adds a missing dependency check. ## Summary - \`deploy.sh\` and the Start/Stop/Update/Reconfigure actions in the settings UI all call \`docker compose\`, but \`preinstall.sh\` never verified it exists. On stock Unraid 6.12+ without the Compose Manager plugin from Community Applications, the install finishes clean and every button then fails at runtime with a cryptic 'command not found'. - Added \`check_docker_compose()\` that runs \`docker compose version\` and aborts with a clear pointer to the Compose Manager plugin, matching the existing \`check_nvidia()\` pattern. - Version bumped to 2026.04.25 in gow.plg and scripts/vars.sh so the release workflow picks it up on tag. 2026.04.24 was already consumed by #19 and the workflow's tag regex is strict YYYY.MM.DD. ## Test plan - [ ] On an Unraid 6.12+ system without Compose Manager: install the plugin, confirm preinstall aborts with the 'install Compose Manager' message. - [ ] Install Compose Manager from CA, retry, confirm preinstall succeeds and the GoW install completes. - [ ] Tag 2026.04.25 after merge to trigger the release workflow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:55:07 +00:00