[PR #23] [MERGED] Warn on missing nvidia_drm.modeset and add FAQ #48

New issue

Closed

opened 2026-10-15 12:55:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:55:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/unraid-plugin/pull/23
Author: @JBailes
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @JBailes

Base: wolf-plugin-rewrite ← Head: nvidia-drm-modeset-faq

📝 Commits (1)

8477f6d Warn when nvidia_drm.modeset is not enabled and add FAQ

📊 Changes

5 files changed (+76 additions, -2 deletions)

View changed files

📝 README.md (+6 -0)
➕ docs/FAQ.md (+30 -0)
📝 gow.plg (+4 -1)
📝 packages/settings-ui/root/usr/local/emhttp/plugins/gow/gow.page (+35 -0)
📝 scripts/vars.sh (+1 -1)

📄 Description

Stacks on #18. Does not automate the fix (modeset is a kernel module parameter; silently flipping it could affect anything else that touches nvidia_drm). Instead: detect, warn, document.

Summary

`gow.page` reads `/sys/module/nvidia_drm/parameters/modeset` on every page load via a new `nvidia_drm_modeset_ok()` helper.
When NVIDIA hardware is present (any detected GPU on the setup form, or the configured GPU on the dashboard) and modeset is not `Y`, a red warning block appears pointing at Tools > System Drivers and linking to the FAQ.
New `docs/FAQ.md` with an `nvidia_drm.modeset` section: the check command, the fix steps (Tools > System Drivers > set modeset to 1 > apply > reboot), and a reference to the Unraid forum discussion.
README gets a Troubleshooting section pointing at the FAQ.
Version bumped to 2026.04.26.

Test plan

On an NVIDIA system with modeset off: fresh install shows the setup-form warning; after deploying (if you proceed anyway), the dashboard shows the same warning.
On an NVIDIA system with modeset=Y: no warning in either place.
On a non-NVIDIA system: no warning (the helper short-circuits on the vendor check).
FAQ link opens to the right anchor on the repo's main branch after this merges to main.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/unraid-plugin/pull/23 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `wolf-plugin-rewrite` ← **Head:** `nvidia-drm-modeset-faq` --- ### 📝 Commits (1) - [`8477f6d`](https://github.com/games-on-whales/unraid-plugin/commit/8477f6dd5259894402896c4cd1e56941a197f110) Warn when nvidia_drm.modeset is not enabled and add FAQ ### 📊 Changes **5 files changed** (+76 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+6 -0) ➕ `docs/FAQ.md` (+30 -0) 📝 `gow.plg` (+4 -1) 📝 `packages/settings-ui/root/usr/local/emhttp/plugins/gow/gow.page` (+35 -0) 📝 `scripts/vars.sh` (+1 -1) </details> ### 📄 Description Stacks on #18. Does not automate the fix (modeset is a kernel module parameter; silently flipping it could affect anything else that touches nvidia_drm). Instead: detect, warn, document. ## Summary - \`gow.page\` reads \`/sys/module/nvidia_drm/parameters/modeset\` on every page load via a new \`nvidia_drm_modeset_ok()\` helper. - When NVIDIA hardware is present (any detected GPU on the setup form, or the configured GPU on the dashboard) and modeset is not \`Y\`, a red warning block appears pointing at **Tools > System Drivers** and linking to the FAQ. - New \`docs/FAQ.md\` with an \`nvidia_drm.modeset\` section: the check command, the fix steps (Tools > System Drivers > set modeset to 1 > apply > reboot), and a reference to the Unraid forum discussion. - README gets a Troubleshooting section pointing at the FAQ. - Version bumped to 2026.04.26. ## Test plan - [ ] On an NVIDIA system with modeset off: fresh install shows the setup-form warning; after deploying (if you proceed anyway), the dashboard shows the same warning. - [ ] On an NVIDIA system with modeset=Y: no warning in either place. - [ ] On a non-NVIDIA system: no warning (the helper short-circuits on the vendor check). - [ ] FAQ link opens to the right anchor on the repo's main branch after this merges to main. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:55:10 +00:00