[PR #26] [MERGED] Nest settings page under User Utilities, theme-aware CSS #49

New issue

Closed

opened 2026-10-15 12:55:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:55:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/unraid-plugin/pull/26
Author: @JBailes
Created: 5/8/2026
Status: ✅ Merged
Merged: 5/8/2026
Merged by: @JBailes

Base: main ← Head: fix/settings-page-placement-and-theme

📝 Commits (1)

d0b3c6c Nest settings page under User Utilities, theme-aware CSS

📊 Changes

3 files changed (+47 additions, -27 deletions)

View changed files

📝 gow.plg (+5 -1)
📝 packages/settings-ui/root/usr/local/emhttp/plugins/gow/gow.page (+41 -25)
📝 scripts/vars.sh (+1 -1)

📄 Description

Summary

Two user reports from the 2026.04.26 release:

Settings page placement — the GoW page rendered as a top-level row on the main Settings page rather than nested under User Utilities. Switching Menu="Settings" → Menu="OtherSettings" in gow.page puts the icon under User Utilities like every other CA plugin. launch="Settings/gow" in gow.plg continues to work unchanged.
Black text on dark cards on light themes — the page CSS hard-coded a dark palette (#1e1e2e cards, etc.) but never set color, so card text inherited the theme's body colour and went dark-on-dark on the white / azure themes.

Approach

Replaced the hard-coded palette with Unraid's theme-aware CSS variables, defined in webgui/emhttp/plugins/dynamix/styles/default-color-palette.css and themes/{theme}.css. The page now picks up:

--text-color, --alt-text-color, --background-color, --mild-background-color, --border-color, --input-border-color for the chrome
--green-500, --red-800, --orange-300, --blue-700, --gray-500 for buttons / status badges / warnings (these are palette constants, but the surrounding text/bg vars track the theme so contrast stays correct)

Pulled the inline style="color:#ef9a9a" / style="color:#ffcc80" / etc. into named classes (.gow-warn, .gow-error, .gow-status-running, .gow-status-stopped, .gow-status-restarting, .gow-status-unknown, .gow-msg-link) so the page no longer has any hard-coded hex.

Test plan

Install on a 6.12+ Unraid host; verify the GoW icon now appears under Settings → User Utilities rather than at the top of the main Settings page.
Switch through white, azure, gray, black themes and verify the GoW page is readable on each — cards, labels, status badges, log output, error/warning paragraphs, message banners.
Confirm Start / Stop / Update Images / Reconfigure buttons still render with their usual colours (green / gray / gray / red).
Confirm the deploy log still streams legibly during a fresh deploy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/unraid-plugin/pull/26 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/8/2026 **Status:** ✅ Merged **Merged:** 5/8/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/settings-page-placement-and-theme` --- ### 📝 Commits (1) - [`d0b3c6c`](https://github.com/games-on-whales/unraid-plugin/commit/d0b3c6cba65501c54e3e9e43626d56930dc59cee) Nest settings page under User Utilities, theme-aware CSS ### 📊 Changes **3 files changed** (+47 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `gow.plg` (+5 -1) 📝 `packages/settings-ui/root/usr/local/emhttp/plugins/gow/gow.page` (+41 -25) 📝 `scripts/vars.sh` (+1 -1) </details> ### 📄 Description ## Summary Two user reports from the 2026.04.26 release: 1. **Settings page placement** — the GoW page rendered as a top-level row on the main Settings page rather than nested under User Utilities. Switching `Menu="Settings"` → `Menu="OtherSettings"` in `gow.page` puts the icon under User Utilities like every other CA plugin. `launch="Settings/gow"` in `gow.plg` continues to work unchanged. 2. **Black text on dark cards on light themes** — the page CSS hard-coded a dark palette (`#1e1e2e` cards, etc.) but never set `color`, so card text inherited the theme's body colour and went dark-on-dark on the white / azure themes. ## Approach Replaced the hard-coded palette with Unraid's theme-aware CSS variables, defined in `webgui/emhttp/plugins/dynamix/styles/default-color-palette.css` and `themes/{theme}.css`. The page now picks up: - `--text-color`, `--alt-text-color`, `--background-color`, `--mild-background-color`, `--border-color`, `--input-border-color` for the chrome - `--green-500`, `--red-800`, `--orange-300`, `--blue-700`, `--gray-500` for buttons / status badges / warnings (these are palette constants, but the surrounding text/bg vars track the theme so contrast stays correct) Pulled the inline `style="color:#ef9a9a"` / `style="color:#ffcc80"` / etc. into named classes (`.gow-warn`, `.gow-error`, `.gow-status-running`, `.gow-status-stopped`, `.gow-status-restarting`, `.gow-status-unknown`, `.gow-msg-link`) so the page no longer has any hard-coded hex. ## Test plan - [ ] Install on a 6.12+ Unraid host; verify the GoW icon now appears under **Settings → User Utilities** rather than at the top of the main Settings page. - [ ] Switch through **white**, **azure**, **gray**, **black** themes and verify the GoW page is readable on each — cards, labels, status badges, log output, error/warning paragraphs, message banners. - [ ] Confirm Start / Stop / Update Images / Reconfigure buttons still render with their usual colours (green / gray / gray / red). - [ ] Confirm the deploy log still streams legibly during a fresh deploy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:55:10 +00:00