[GH-ISSUE #206] External URLs in icon_png_path don't work, docs suggest otherwise #138

New issue

Closed

opened 2026-10-15 12:57:02 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-15 12:57:02 +00:00

Owner

Originally created by @shawly on GitHub (May 28, 2025).
Original GitHub issue: https://github.com/games-on-whales/wolf/issues/206

On the wildlife page all the example configs contain a http URL to a cover image e.g.:
github.com/games-on-whales/gow@5006e1beb8/apps/steam/assets/wolf.config.toml (L3)

But wolf doesn't check if it's an external URL or a file path since ifstream only works for local files:
github.com/games-on-whales/wolf@1a6327d6e2/src/moonlight-server/rest/endpoints.hpp (L358)

This results in the following log warnings:

16:45:47.495006161 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png
16:45:47.493080777 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png
16:45:47.489089917 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png
16:45:47.517642707 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/steam/assets/icon.png
16:45:47.517482046 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/retroarch/assets/icon.png
16:45:47.516462102 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/prismlauncher/assets/icon.png
16:45:47.513406036 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/steam/assets/icon.png
16:45:47.512774631 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/retroarch/assets/icon.png
16:45:47.512613408 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/prismlauncher/assets/icon.png
16:45:47.511905820 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/pegasus/assets/icon.png
16:45:47.508873559 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/kodi/assets/icon.png
16:45:47.508680857 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/lutris/assets/icon.png
16:45:47.507165222 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/heroic-games-launcher/assets/icon.png
16:45:47.504385745 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/lutris/assets/icon.png
16:45:47.504600929 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/pegasus/assets/icon.png
16:45:47.503983060 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/kodi/assets/icon.png
16:45:47.500256906 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/heroic-games-launcher/assets/icon.png
16:45:47.499617306 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/firefox/assets/icon.png
16:45:47.498767731 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png
16:45:47.498958289 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/es-de/assets/icon.png
16:45:47.494803180 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/firefox/assets/icon.png
16:45:47.493946713 WARN  | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/es-de/assets/icon.png

So either we should fix the docs and correct the urls, or fix that functionality in wolf.

Originally created by @shawly on GitHub (May 28, 2025). Original GitHub issue: https://github.com/games-on-whales/wolf/issues/206 On the wildlife page all the example configs contain a http URL to a cover image e.g.: https://github.com/games-on-whales/gow/blob/5006e1beb8b7b78c603437fcf1c87db922d2de26/apps/steam/assets/wolf.config.toml#L3 But wolf doesn't check if it's an external URL or a file path since ifstream only works for local files: https://github.com/games-on-whales/wolf/blob/1a6327d6e251d808581b825edaf5ed81967ff3f0/src/moonlight-server/rest/endpoints.hpp#L358 This results in the following log warnings: ``` 16:45:47.495006161 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png 16:45:47.493080777 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png 16:45:47.489089917 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png 16:45:47.517642707 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/steam/assets/icon.png 16:45:47.517482046 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/retroarch/assets/icon.png 16:45:47.516462102 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/prismlauncher/assets/icon.png 16:45:47.513406036 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/steam/assets/icon.png 16:45:47.512774631 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/retroarch/assets/icon.png 16:45:47.512613408 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/prismlauncher/assets/icon.png 16:45:47.511905820 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/pegasus/assets/icon.png 16:45:47.508873559 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/kodi/assets/icon.png 16:45:47.508680857 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/lutris/assets/icon.png 16:45:47.507165222 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/heroic-games-launcher/assets/icon.png 16:45:47.504385745 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/lutris/assets/icon.png 16:45:47.504600929 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/pegasus/assets/icon.png 16:45:47.503983060 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/kodi/assets/icon.png 16:45:47.500256906 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/heroic-games-launcher/assets/icon.png 16:45:47.499617306 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/firefox/assets/icon.png 16:45:47.498767731 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/xfce/assets/icon.png 16:45:47.498958289 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/es-de/assets/icon.png 16:45:47.494803180 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/firefox/assets/icon.png 16:45:47.493946713 WARN | Could not open configured asset: /srv/wolf/data/https://games-on-whales.github.io/wildlife/apps/es-de/assets/icon.png ``` So either we should fix the docs and correct the urls, or fix that functionality in wolf.

bsakaguchi

2026-10-15 12:57:02 +00:00

closed this issue
added the
enhancement
label

bsakaguchi commented

2026-10-15 12:57:03 +00:00

Author

Owner

@ABeltramo commented on GitHub (May 28, 2025):

Thanks for opening this, I was definitely planning on supporting URLs on that field but got sidetracked by other PRs.

@ABeltramo commented on GitHub (May 28, 2025): Thanks for opening this, I was definitely planning on supporting URLs on that field but got sidetracked by other PRs.