[PR #252] [MERGED] Support 2/6/8 channel audio with correct GStreamer masks in streamin… #396

Closed
opened 2026-10-15 13:00:16 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolf/pull/252
Author: @Gylfkxjyjdll
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/18/2025
Merged by: @ABeltramo

Base: stable ← Head: patch-1


📝 Commits (2)

  • 6e6b51b Support 2/6/8 channel audio with correct GStreamer masks in streaming.cpp
  • 0452fd2 fix: lint

📊 Changes

1 file changed (+20 additions, -4 deletions)

View changed files

📝 src/moonlight-server/streaming/streaming.cpp (+20 -4)

📄 Description

…g.cpp

What this PR does

  • Adds dynamic channel mask support in start_audio_producer() based on the number of channels.
  • When channel_count = 2, applies standard stereo mask (0x3).
  • When channel_count = 6, applies 5.1 surround mask (0x3f).
  • When channel_count = 8, applies 7.1 surround mask (0xc3f).

Why this is needed

  • Ensures proper channel mapping when processing multi-channel audio in GStreamer.
  • Prevents undefined behavior with unmasked multi-channel audio.
  • Keeps compatibility with standard surround sound layouts.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolf/pull/252 **Author:** [@Gylfkxjyjdll](https://github.com/Gylfkxjyjdll) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/18/2025 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `stable` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`6e6b51b`](https://github.com/games-on-whales/wolf/commit/6e6b51bd273456fefe588358d1f12683f377cff1) Support 2/6/8 channel audio with correct GStreamer masks in streaming.cpp - [`0452fd2`](https://github.com/games-on-whales/wolf/commit/0452fd2d359c2de4d29333ede83157e7bfcf76e7) fix: lint ### 📊 Changes **1 file changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/moonlight-server/streaming/streaming.cpp` (+20 -4) </details> ### 📄 Description …g.cpp ### What this PR does - Adds dynamic channel mask support in `start_audio_producer()` based on the number of channels. - When `channel_count = 2`, applies standard stereo mask (`0x3`). - When `channel_count = 6`, applies 5.1 surround mask (`0x3f`). - When `channel_count = 8`, applies 7.1 surround mask (`0xc3f`). ### Why this is needed - Ensures proper channel mapping when processing multi-channel audio in GStreamer. - Prevents undefined behavior with unmasked multi-channel audio. - Keeps compatibility with standard surround sound layouts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 13:00:16 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/wolf#396
No description provided.