[PR #391] [CLOSED] test: HTTPS server must allow session resumption with client cert #438

New issue

Closed

opened 2026-10-15 13:00:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:00:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolf/pull/391
Author: @BenSmith
Created: 4/12/2026
Status: ❌ Closed

Base: stable ← Head: test/https-session-resumption

📝 Commits (1)

5806a65 test: HTTPS server must allow session resumption with client cert

📊 Changes

2 files changed (+135 additions, -1 deletions)

View changed files

📝 tests/CMakeLists.txt (+2 -1)
➕ tests/testHTTPS.cpp (+133 -0)

📄 Description

Adds an integration test that spins up Wolf's Server on an ephemeral port and issues two consecutive TLS handshakes with a client certificate over a reusable libcurl handle. The second handshake exercises OpenSSL's session resumption path, which aborts with "session id context uninitialized" unless the server has called SSL_CTX_set_session_id_context() on its SSL_CTX.

On stable this test currently fails: the fix lives in a separate PR.

I did not see other similar integration tests and I am not trying to set precedent for them with this PR, feel free to ignore this if you do not want it.

Edited to add: This is AI-generated code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolf/pull/391 **Author:** [@BenSmith](https://github.com/BenSmith) **Created:** 4/12/2026 **Status:** ❌ Closed **Base:** `stable` ← **Head:** `test/https-session-resumption` --- ### 📝 Commits (1) - [`5806a65`](https://github.com/games-on-whales/wolf/commit/5806a6581aa36b91c77c7e17d497179570017f9b) test: HTTPS server must allow session resumption with client cert ### 📊 Changes **2 files changed** (+135 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/CMakeLists.txt` (+2 -1) ➕ `tests/testHTTPS.cpp` (+133 -0) </details> ### 📄 Description Adds an integration test that spins up Wolf's Server<HTTPS> on an ephemeral port and issues two consecutive TLS handshakes with a client certificate over a reusable libcurl handle. The second handshake exercises OpenSSL's session resumption path, which aborts with "session id context uninitialized" unless the server has called `SSL_CTX_set_session_id_context()` on its `SSL_CTX`. On stable this test currently fails: the [fix lives in a separate PR](https://github.com/games-on-whales/wolf/pull/390). I did not see other similar integration tests and I am not trying to set precedent for them with this PR, feel free to ignore this if you do not want it. Edited to add: This is AI-generated code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:00:34 +00:00