[PR #393] [CLOSED] Fix session containers to run as retro #440

New issue

Closed

opened 2026-10-15 13:00:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:00:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolf/pull/393
Author: @JBailes
Created: 4/18/2026
Status: ❌ Closed

Base: stable ← Head: fix/session-runner-user

📝 Commits (2)

054b7c7 Fix session containers to run as retro
7270bb1 Fix runner test config namespace

📊 Changes

3 files changed (+82 additions, -0 deletions)

View changed files

📝 src/moonlight-server/sessions/common.cpp (+1 -0)
📝 tests/CMakeLists.txt (+1 -0)
➕ tests/testRunner.cpp (+80 -0)

📄 Description

Summary

set UNAME=retro for Wolf-launched session containers alongside the existing PUID and PGID overrides
add a regression test around sessions::start_runner so session container env construction keeps the non-root runtime user

Root Cause

Wolf already overrides the numeric runtime IDs for session containers, but it does not override UNAME. GoW images such as wolf-ui default that variable to root, and the base entrypoint only switches to the non-root path when UNAME != root. That leaves session containers running as root even when Wolf is trying to launch them with the paired client's runtime UID/GID.

Validation

git diff --check
added a focused start_runner regression test covering the session env

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolf/pull/393 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/18/2026 **Status:** ❌ Closed **Base:** `stable` ← **Head:** `fix/session-runner-user` --- ### 📝 Commits (2) - [`054b7c7`](https://github.com/games-on-whales/wolf/commit/054b7c7de5a08d4f2f2f217720a5a307263282b8) Fix session containers to run as retro - [`7270bb1`](https://github.com/games-on-whales/wolf/commit/7270bb1658129755fc39477d153521cda1bfb812) Fix runner test config namespace ### 📊 Changes **3 files changed** (+82 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/moonlight-server/sessions/common.cpp` (+1 -0) 📝 `tests/CMakeLists.txt` (+1 -0) ➕ `tests/testRunner.cpp` (+80 -0) </details> ### 📄 Description ## Summary - set `UNAME=retro` for Wolf-launched session containers alongside the existing `PUID` and `PGID` overrides - add a regression test around `sessions::start_runner` so session container env construction keeps the non-root runtime user ## Root Cause Wolf already overrides the numeric runtime IDs for session containers, but it does not override `UNAME`. GoW images such as `wolf-ui` default that variable to `root`, and the base entrypoint only switches to the non-root path when `UNAME != root`. That leaves session containers running as root even when Wolf is trying to launch them with the paired client's runtime UID/GID. ## Validation - `git diff --check` - added a focused `start_runner` regression test covering the session env --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:00:35 +00:00