[PR #466] [MERGED] fix(api): keep start_audio_server when deserialising an App #483

New issue

Closed

opened 2026-10-15 13:00:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:00:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolf/pull/466
Author: @WMP
Created: 7/25/2026
Status: ✅ Merged
Merged: 8/8/2026
Merged by: @ABeltramo

Base: stable ← Head: fix/api-apps-add-start-audio-server

📝 Commits (1)

00e16b1 fix(api): keep start_audio_server when deserialising an App

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/moonlight-server/events/reflectors.hpp (+1 -0)

📄 Description

Reflector<events::App>::to() rebuilt the events::App without
start_audio_server, so aggregate initialisation left it false. Every app
created through POST /api/v1/apps/add therefore had its audio server disabled,
no matter what the request said: the session came up with a virtual compositor
but no virtual_sink_<session_id>, in-app streams fell back to auto_null and
Moonlight got silence.

from() in the same file copies the field, and configTOML.cpp reads
(value_or(true)) and writes it, so apps defined in config.toml behaved
correctly — which is why the API reported false rather than omitting the key,
and why this was easy to miss.

The start_virtual_compositor line right above shows the intended shape; this
adds the matching assignment for the audio flag.

Details, reproduction and the user-visible symptoms are in #465.

Fixes #465

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolf/pull/466 **Author:** [@WMP](https://github.com/WMP) **Created:** 7/25/2026 **Status:** ✅ Merged **Merged:** 8/8/2026 **Merged by:** [@ABeltramo](https://github.com/ABeltramo) **Base:** `stable` ← **Head:** `fix/api-apps-add-start-audio-server` --- ### 📝 Commits (1) - [`00e16b1`](https://github.com/games-on-whales/wolf/commit/00e16b11699672affc63eb9f3d90d07b1726f459) fix(api): keep start_audio_server when deserialising an App ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/moonlight-server/events/reflectors.hpp` (+1 -0) </details> ### 📄 Description `Reflector<events::App>::to()` rebuilt the `events::App` without `start_audio_server`, so aggregate initialisation left it `false`. Every app created through `POST /api/v1/apps/add` therefore had its audio server disabled, no matter what the request said: the session came up with a virtual compositor but no `virtual_sink_<session_id>`, in-app streams fell back to `auto_null` and Moonlight got silence. `from()` in the same file copies the field, and `configTOML.cpp` reads (`value_or(true)`) and writes it, so apps defined in `config.toml` behaved correctly — which is why the API *reported* `false` rather than omitting the key, and why this was easy to miss. The `start_virtual_compositor` line right above shows the intended shape; this adds the matching assignment for the audio flag. Details, reproduction and the user-visible symptoms are in #465. Fixes #465 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:00:55 +00:00