[PR #33] [MERGED] Fix critical security vulnerability: prevent credentials from appearing #51

Closed
opened 2026-10-15 13:01:57 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolfmanager/pull/33
Author: @salty2011
Created: 6/15/2025
Status: ✅ Merged
Merged: 6/15/2025
Merged by: @salty2011

Base: release/202506.003 ← Head: fix-login-url-credentials


📝 Commits (1)

  • c31eb60 Fix critical security vulnerability: prevent credentials from appearing in URL

📊 Changes

1 file changed (+22 additions, -8 deletions)

View changed files

📝 src/components/auth/login-form.tsx (+22 -8)

📄 Description

Summary

  • Changed signIn redirect from true to false to prevent NextAuth from exposing credentials in URL parameters
  • Added proper error handling to reset isLoading state on failed login attempts
  • Added debug logging to track authentication flow
  • Manually handle redirect to /clients on successful login
  • Fixes issue where input fields became disabled after failed login

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolfmanager/pull/33 **Author:** [@salty2011](https://github.com/salty2011) **Created:** 6/15/2025 **Status:** ✅ Merged **Merged:** 6/15/2025 **Merged by:** [@salty2011](https://github.com/salty2011) **Base:** `release/202506.003` ← **Head:** `fix-login-url-credentials` --- ### 📝 Commits (1) - [`c31eb60`](https://github.com/games-on-whales/wolfmanager/commit/c31eb60dc45557a2582892eb6ab439557e7a8313) Fix critical security vulnerability: prevent credentials from appearing in URL ### 📊 Changes **1 file changed** (+22 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/components/auth/login-form.tsx` (+22 -8) </details> ### 📄 Description **Summary** - Changed signIn redirect from true to false to prevent NextAuth from exposing credentials in URL parameters - Added proper error handling to reset isLoading state on failed login attempts - Added debug logging to track authentication flow - Manually handle redirect to /clients on successful login - Fixes issue where input fields became disabled after failed login --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 13:01:57 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/wolfmanager#51
No description provided.