[PR #47] [MERGED] Fix client settings loading from Wolf API when editing paired clients #57

New issue

Closed

opened 2026-10-15 13:02:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 13:02:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/wolfmanager/pull/47
Author: @salty2011
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/11/2025
Merged by: @salty2011

Base: release/202506.004 ← Head: fix/client-settings-issues

📝 Commits (1)

1c6d42a fix: Enhance client settings loading with Wolf API integration

📊 Changes

1 file changed (+88 additions, -16 deletions)

View changed files

📝 src/app/clients/actions/synchronization.ts (+88 -16)

📄 Description

Problem

When editing paired client settings, the dialog was showing default values (e.g., "auto" instead of "XBOX") because the getPairedClientsWithSettingsAction() function only queried the local database, which doesn't store client settings.

Solution

Enhanced the getPairedClientsWithSettingsAction() function to:

Added Wolf API integration to fetch current client settings from /clients endpoint
Implemented data merging between database metadata and Wolf API settings
Added format transformation (Wolf API uppercase → form lowercase for controllers)
Robust error handling with graceful fallback when Wolf API unavailable
Enhanced client matching using wolfClientId

Changes

Files Modified: src/app/clients/actions/synchronization.ts
Changes: 88 insertions, 16 deletions
Testing: Build verification and code review completed

Result

Client edit dialog now properly loads and displays current settings from Wolf API instead of defaulting to empty values.

Fixes issue where controller settings would show as "auto" instead of the actual configured value like "XBOX".

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/wolfmanager/pull/47 **Author:** [@salty2011](https://github.com/salty2011) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/11/2025 **Merged by:** [@salty2011](https://github.com/salty2011) **Base:** `release/202506.004` ← **Head:** `fix/client-settings-issues` --- ### 📝 Commits (1) - [`1c6d42a`](https://github.com/games-on-whales/wolfmanager/commit/1c6d42acea5c48b3caf6fe8962de3dbbe95817a9) fix: Enhance client settings loading with Wolf API integration ### 📊 Changes **1 file changed** (+88 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/app/clients/actions/synchronization.ts` (+88 -16) </details> ### 📄 Description ## Problem When editing paired client settings, the dialog was showing default values (e.g., "auto" instead of "XBOX") because the `getPairedClientsWithSettingsAction()` function only queried the local database, which doesn't store client settings. ## Solution Enhanced the `getPairedClientsWithSettingsAction()` function to: - Added Wolf API integration to fetch current client settings from `/clients` endpoint - Implemented data merging between database metadata and Wolf API settings - Added format transformation (Wolf API uppercase → form lowercase for controllers) - Robust error handling with graceful fallback when Wolf API unavailable - Enhanced client matching using `wolfClientId` ## Changes - **Files Modified**: `src/app/clients/actions/synchronization.ts` - **Changes**: 88 insertions, 16 deletions - **Testing**: Build verification and code review completed ## Result Client edit dialog now properly loads and displays current settings from Wolf API instead of defaulting to empty values. Fixes issue where controller settings would show as "auto" instead of the actual configured value like "XBOX". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 13:02:00 +00:00