From 5e1944bdec7d97af5309ff45ed7727b085abfbd8 Mon Sep 17 00:00:00 2001 From: Iwan Kawrakow Date: Fri, 21 Mar 2025 14:17:48 +0200 Subject: [PATCH] Fix bug: missing parentheses in logical expression This results in GGGGGGGGGGGGG when generating with mla = 3, fa = 0. --- src/llama.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/llama.cpp b/src/llama.cpp index dfe445b8..186cb5a5 100644 --- a/src/llama.cpp +++ b/src/llama.cpp @@ -13869,7 +13869,7 @@ struct llm_build_context { ggml_tensor * q = ggml_concat(ctx0, q_nope2, ggml_permute(ctx0, q_rope, 0, 2, 1, 3), 0); cb(q, "q", il); - if (lctx.cparams.flash_attn && lctx.cparams.mla_attn == 1 || lctx.cparams.mla_attn == 3) { + if (lctx.cparams.flash_attn && (lctx.cparams.mla_attn == 1 || lctx.cparams.mla_attn == 3)) { ggml_tensor * kv_cache_lora = ggml_view_2d(ctx0, kv_self.kv_l[il], kv_lora_rank, n_kv, ggml_row_size(kv_self.kv_l[il]->type, kv_lora_rank + n_embd_head_qk_rope), 0);