ikawrakow/ik_llama.cpp
1
0
Fork 0
mirror of https://github.com/ikawrakow/ik_llama.cpp.git synced 2026-03-08 04:50:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix adaptive p sampler rewinding too far back (#1359)

Browse Source 
* fix adaptive p sampler rewinding too far back

* update comments

* correct default value for total_weight, more comments

* new variables/names

* update comment for n_rewind

* move null pointer check back to common_sampler_review()

* refactor weighted_sum and total_weight to vector<pair>, better boundary check in llama_review_adaptive_p_impl()
This commit is contained in:
dungquixote42
2026-03-04 07:26:25 -05:00
committed by GitHub
parent f27678d39b
commit a903409a5e
7 changed files with 75 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
common/sampling.cpp
View File

@@ -106,6 +106,8 @@ struct common_sampler * common_sampler_init(const struct llama_model * model, co
}
}
result->n_rewind = -1;
return result;
}
@@ -143,16 +145,12 @@ void common_sampler_reset(common_sampler * ctx) {
}
void common_sampler_review(common_sampler * ctx) {
if (!ctx->adapt_p_ctx) {
return;
const int32_t n_rewind = ctx->n_rewind;
// add stateful samplers here
if (ctx->adapt_p_ctx != nullptr) {
llama_review_adaptive_p(ctx->adapt_p_ctx, n_rewind);
}
const bool record = ctx->record_samplers;
const bool rewind = ctx->rewind_samplers;
llama_review_adaptive_p(ctx->adapt_p_ctx, record, rewind);
ctx->record_samplers = false;
ctx->rewind_samplers = false;
}
void llama_sampling_set_rng_seed(struct common_sampler * ctx, uint32_t seed) {