[PR #142] [MERGED] refactor(ublk): remove the legacy CoW target #205

New issue

Closed

opened 2026-10-29 14:20:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:20:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/142
Author: @yingdi-shan
Created: 8/8/2026
Status: ✅ Merged
Merged: 8/8/2026
Merged by: @yingdi-shan

Base: main ← Head: refactor/remove-legacy-cow-target

📝 Commits (1)

f8df4d6 refactor: remove legacy CoW target

📊 Changes

26 files changed (+117 additions, -1903 deletions)

View changed files

📝 CLAUDE.md (+3 -3)
📝 Cargo.lock (+0 -3)
📝 config/default.toml (+0 -2)
📝 config/oss_default.toml (+0 -2)
📝 docs/src/configuration/reference.md (+2 -4)
📝 docs/src/internals/architecture.md (+4 -6)
📝 docs/src/internals/sandbox-testing.md (+1 -4)
📝 src/api/impls/template_helpers.rs (+0 -18)
📝 src/cfg.rs (+0 -4)
📝 src/sandbox/firecracker/config.rs (+13 -46)
📝 src/sandbox/firecracker/sandbox.rs (+12 -25)
📝 src/sandbox/ublk/device.rs (+49 -28)
📝 src/setup/deps.rs (+0 -2)
📝 src/setup/mod.rs (+4 -10)
📝 src/template/builder.rs (+4 -12)
📝 storage/ublk-daemon/src/client.rs (+0 -28)
📝 storage/ublk-daemon/src/protocol.rs (+0 -23)
📝 storage/ublk-daemon/src/server.rs (+9 -76)
📝 storage/ublk-daemon/tests/ublk_daemon_test.rs (+8 -87)
📝 storage/ublk/Cargo.toml (+0 -3)

...and 6 more files

📄 Description

Summary

remove BasicCowTarget, its public API, standalone CLI target, tests, and CoW-only dependencies
remove CreateCow from the ublk daemon protocol, client, server, and managed-device lifecycle
make OverlayBD the sole, always-on ublk backend and remove the legacy ublk.enabled and ublk.device_type settings
reject persisted CoW sandbox state with clear OverlayBD migration guidance
update ublk architecture, configuration, testing, contributor, and CLI documentation

Legacy enabled and device_type TOML keys are ignored by the configuration loader.

Closes #140

Validation

cargo fmt --all --check
cargo clippy -p uvm-ublk -p uvm-ublk-daemon --all-targets -- -D warnings
cargo clippy -p agentenv --lib -- -D warnings
cargo test -p uvm-ublk --lib
cargo test -p uvm-ublk-daemon
focused AgentENV OverlayBD binding, persisted-state migration, and bundled-config tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/142 **Author:** [@yingdi-shan](https://github.com/yingdi-shan) **Created:** 8/8/2026 **Status:** ✅ Merged **Merged:** 8/8/2026 **Merged by:** [@yingdi-shan](https://github.com/yingdi-shan) **Base:** `main` ← **Head:** `refactor/remove-legacy-cow-target` --- ### 📝 Commits (1) - [`f8df4d6`](https://github.com/kvcache-ai/AgentENV/commit/f8df4d691251f6b2e7710001a9141cbcb9d5582e) refactor: remove legacy CoW target ### 📊 Changes **26 files changed** (+117 additions, -1903 deletions) <details> <summary>View changed files</summary> 📝 `CLAUDE.md` (+3 -3) 📝 `Cargo.lock` (+0 -3) 📝 `config/default.toml` (+0 -2) 📝 `config/oss_default.toml` (+0 -2) 📝 `docs/src/configuration/reference.md` (+2 -4) 📝 `docs/src/internals/architecture.md` (+4 -6) 📝 `docs/src/internals/sandbox-testing.md` (+1 -4) 📝 `src/api/impls/template_helpers.rs` (+0 -18) 📝 `src/cfg.rs` (+0 -4) 📝 `src/sandbox/firecracker/config.rs` (+13 -46) 📝 `src/sandbox/firecracker/sandbox.rs` (+12 -25) 📝 `src/sandbox/ublk/device.rs` (+49 -28) 📝 `src/setup/deps.rs` (+0 -2) 📝 `src/setup/mod.rs` (+4 -10) 📝 `src/template/builder.rs` (+4 -12) 📝 `storage/ublk-daemon/src/client.rs` (+0 -28) 📝 `storage/ublk-daemon/src/protocol.rs` (+0 -23) 📝 `storage/ublk-daemon/src/server.rs` (+9 -76) 📝 `storage/ublk-daemon/tests/ublk_daemon_test.rs` (+8 -87) 📝 `storage/ublk/Cargo.toml` (+0 -3) _...and 6 more files_ </details> ### 📄 Description ## Summary - remove `BasicCowTarget`, its public API, standalone CLI target, tests, and CoW-only dependencies - remove `CreateCow` from the ublk daemon protocol, client, server, and managed-device lifecycle - make OverlayBD the sole, always-on ublk backend and remove the legacy `ublk.enabled` and `ublk.device_type` settings - reject persisted CoW sandbox state with clear OverlayBD migration guidance - update ublk architecture, configuration, testing, contributor, and CLI documentation Legacy `enabled` and `device_type` TOML keys are ignored by the configuration loader. Closes #140 ## Validation - [x] `cargo fmt --all --check` - [x] `cargo clippy -p uvm-ublk -p uvm-ublk-daemon --all-targets -- -D warnings` - [x] `cargo clippy -p agentenv --lib -- -D warnings` - [x] `cargo test -p uvm-ublk --lib` - [x] `cargo test -p uvm-ublk-daemon` - [x] focused AgentENV OverlayBD binding, persisted-state migration, and bundled-config tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:20:59 +00:00