[PR #152] [MERGED] fix(p2p): do not cache lookup timeouts as misses #214

New issue

Closed

opened 2026-10-29 14:21:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:21:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/152
Author: @WindSongShaoGe
Created: 8/11/2026
Status: ✅ Merged
Merged: 8/14/2026
Merged by: @yingdi-shan

Base: main ← Head: fix/p2p-timeout-negative-cache

📝 Commits (1)

a44ca6c fix(p2p): do not cache lookup timeouts as misses

📊 Changes

1 file changed (+40 additions, -2 deletions)

View changed files

📝 src/overlaybd/p2p/facade.rs (+40 -2)

📄 Description

Summary

avoid inserting a negative descriptor-cache entry when a P2P lookup times out
allow the next layer read to retry peer lookup instead of falling back to the origin for the full miss TTL
add a regression test covering repeated reads after lookup timeouts

Why

A lookup timeout means the artifact availability is unknown, not that the
artifact is absent. Caching the timeout as a miss causes subsequent reads for
that layer to fall back to the origin registry until the negative-cache entry
expires.

Validation

make test
result: passed, exit code 0

Refs #138

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/152 **Author:** [@WindSongShaoGe](https://github.com/WindSongShaoGe) **Created:** 8/11/2026 **Status:** ✅ Merged **Merged:** 8/14/2026 **Merged by:** [@yingdi-shan](https://github.com/yingdi-shan) **Base:** `main` ← **Head:** `fix/p2p-timeout-negative-cache` --- ### 📝 Commits (1) - [`a44ca6c`](https://github.com/kvcache-ai/AgentENV/commit/a44ca6c92bec87a1f4e95e95729fc8827c437e14) fix(p2p): do not cache lookup timeouts as misses ### 📊 Changes **1 file changed** (+40 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/overlaybd/p2p/facade.rs` (+40 -2) </details> ### 📄 Description ## Summary - avoid inserting a negative descriptor-cache entry when a P2P lookup times out - allow the next layer read to retry peer lookup instead of falling back to the origin for the full miss TTL - add a regression test covering repeated reads after lookup timeouts ## Why A lookup timeout means the artifact availability is unknown, not that the artifact is absent. Caching the timeout as a miss causes subsequent reads for that layer to fall back to the origin registry until the negative-cache entry expires. ## Validation - `make test` - result: passed, exit code 0 Refs #138 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:21:06 +00:00