[PR #190] [MERGED] feat: enable dirty-page tracking by default #240

New issue

Closed

opened 2026-10-29 14:21:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:21:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/190
Author: @Hygge-Gezelligheid
Created: 8/19/2026
Status: ✅ Merged
Merged: 8/19/2026
Merged by: @yingdi-shan

Base: main ← Head: agent/enable-dirty-page-tracking-default

📝 Commits (2)

82942a2 feat: enable dirty-page tracking by default
0f57486 fix: disable dirty-page tracking for pvm

📊 Changes

5 files changed (+27 additions, -8 deletions)

View changed files

📝 config/default.toml (+3 -3)
📝 docs/src/configuration/reference.md (+1 -1)
📝 docs/src/deployment/pvm.md (+1 -1)
📝 src/cfg.rs (+21 -2)
📝 src/sandbox/firecracker/config.rs (+1 -1)

📄 Description

What

Enable Firecracker KVM dirty-page tracking by default for memory snapshots.

Why

Dirty-page tracking is the intended default path; users can still opt out when needed.

Scope and non-goals

Changes only the default and related documentation.
Keeps the existing PVM validation unchanged.
No runtime behavior beyond the default configuration selection.

Compatibility and operations

Configuration/defaults: memory_snapshot.track_dirty_pages now defaults to true.
Opt out with AGENTENV_MEMORY_SNAPSHOT_TRACK_DIRTY_PAGES=false.
PVM remains unsupported for this option.

Validation

make fmt
make clippy
make test-unit (not run: small default-only change, per task scope)
Documentation updated

Checklist

Focused change with no unrelated refactoring.
No generated code changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/190 **Author:** [@Hygge-Gezelligheid](https://github.com/Hygge-Gezelligheid) **Created:** 8/19/2026 **Status:** ✅ Merged **Merged:** 8/19/2026 **Merged by:** [@yingdi-shan](https://github.com/yingdi-shan) **Base:** `main` ← **Head:** `agent/enable-dirty-page-tracking-default` --- ### 📝 Commits (2) - [`82942a2`](https://github.com/kvcache-ai/AgentENV/commit/82942a2b957e6a58e69a3b174ff0873bb6f9a668) feat: enable dirty-page tracking by default - [`0f57486`](https://github.com/kvcache-ai/AgentENV/commit/0f57486fc99eaab6667a31703c30e7feb31501ff) fix: disable dirty-page tracking for pvm ### 📊 Changes **5 files changed** (+27 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `config/default.toml` (+3 -3) 📝 `docs/src/configuration/reference.md` (+1 -1) 📝 `docs/src/deployment/pvm.md` (+1 -1) 📝 `src/cfg.rs` (+21 -2) 📝 `src/sandbox/firecracker/config.rs` (+1 -1) </details> ### 📄 Description ## What Enable Firecracker KVM dirty-page tracking by default for memory snapshots. ## Why Dirty-page tracking is the intended default path; users can still opt out when needed. ## Scope and non-goals - Changes only the default and related documentation. - Keeps the existing PVM validation unchanged. - No runtime behavior beyond the default configuration selection. ## Compatibility and operations - Configuration/defaults: memory_snapshot.track_dirty_pages now defaults to true. - Opt out with AGENTENV_MEMORY_SNAPSHOT_TRACK_DIRTY_PAGES=false. - PVM remains unsupported for this option. ## Validation - [x] make fmt - [x] make clippy - [ ] make test-unit (not run: small default-only change, per task scope) - [x] Documentation updated ## Checklist - [x] Focused change with no unrelated refactoring. - [x] No generated code changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:21:22 +00:00