[PR #239] [MERGED] fix(sandbox): pass seal output to persistent volume restack #280

New issue

Closed

opened 2026-10-29 14:21:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:21:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/239
Author: @huajq
Created: 9/2/2026
Status: ✅ Merged
Merged: 9/2/2026
Merged by: @LSX-s-Software

Base: main ← Head: fix/volume-snapshot-seal-output

📝 Commits (1)

c026535 fix(sandbox): pass seal output to persistent volume restack

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/sandbox/firecracker/sandbox.rs (+2 -0)

📄 Description

What

Adds the missing seal_output argument (OverlaybdCompactOutput::Raw) to the persistent-volume restack_snapshot_overlaybd_device call site, fixing the build on main.

Why

Two recently merged PRs conflict semantically: the template-build compression switch added a seal_output parameter to restack_snapshot_overlaybd_device, while the volumes feature added a new call site that doesn't pass it — so main fails to compile (E0061, clippy and unit-tests jobs red).

N/A — build fix for the main CI failure.

Scope and non-goals

One-argument call-site fix. Persistent volume seals always stay raw, same as attached drives; no behavior change.

Validation

make fmt
make clippy
make test-unit

cargo clippy -p agentenv --all-targets -- -D warnings   # clean
cargo test -p agentenv --lib overlaybd_snapshot         # 12/12 pass

Checklist

The PR contains one coherent change and no unrelated formatting or refactoring.
New behavior is covered by tests, or I explained why testing is impractical.
Logs and examples contain no credentials, tokens, or private registry information.
I did not manually edit generated code without updating its source and regenerating it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/239 **Author:** [@huajq](https://github.com/huajq) **Created:** 9/2/2026 **Status:** ✅ Merged **Merged:** 9/2/2026 **Merged by:** [@LSX-s-Software](https://github.com/LSX-s-Software) **Base:** `main` ← **Head:** `fix/volume-snapshot-seal-output` --- ### 📝 Commits (1) - [`c026535`](https://github.com/kvcache-ai/AgentENV/commit/c026535a562ac6703cd96fc59f49b1ec1569d8a5) fix(sandbox): pass seal output to persistent volume restack ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/sandbox/firecracker/sandbox.rs` (+2 -0) </details> ### 📄 Description ## What Adds the missing `seal_output` argument (`OverlaybdCompactOutput::Raw`) to the persistent-volume `restack_snapshot_overlaybd_device` call site, fixing the build on `main`. ## Why Two recently merged PRs conflict semantically: the template-build compression switch added a `seal_output` parameter to `restack_snapshot_overlaybd_device`, while the volumes feature added a new call site that doesn't pass it — so `main` fails to compile (`E0061`, clippy and unit-tests jobs red). ## Related issue N/A — build fix for the main CI failure. ## Scope and non-goals One-argument call-site fix. Persistent volume seals always stay raw, same as attached drives; no behavior change. ## Validation - [x] `make fmt` - [x] `make clippy` - [x] `make test-unit` ```text cargo clippy -p agentenv --all-targets -- -D warnings # clean cargo test -p agentenv --lib overlaybd_snapshot # 12/12 pass ``` ## Checklist - [x] The PR contains one coherent change and no unrelated formatting or refactoring. - [x] New behavior is covered by tests, or I explained why testing is impractical. - [x] Logs and examples contain no credentials, tokens, or private registry information. - [x] I did not manually edit generated code without updating its source and regenerating it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:21:46 +00:00