[PR #419] [MERGED] fix(sandbox): hide source image references from guest metadata #421

New issue

Closed

opened 2026-10-29 14:23:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:23:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/AgentENV/pull/419
Author: @guozy18
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/23/2026
Merged by: @yingdi-shan

Base: main ← Head: sync/hide-guest-image-ref

📝 Commits (1)

f6d25cc fix(sandbox): hide image refs from guest metadata

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/orchestrator/service.rs (+2 -1)

📄 Description

What

Use "unknown" for the guest-visible envID of an image-based cold start while retaining the image reference in host-side sandbox metadata.

Why

Cold starts previously copied the source image reference into Firecracker MMDS, exposing registry/repository details to the guest.

N/A — focused correction of existing behavior.

Scope and non-goals

The cold-start SandboxLaunchConfig initialization.

Design and behavior changes

Set only the guest launch identity to "unknown". Host metadata keeps its existing source image reference; snapshot-based launch identity continues to use the snapshot ID.

Compatibility and operations

Cold-start guests now see envID="unknown" instead of the source image reference. Host-facing metadata, API schema, persistent formats, configuration and dependencies are unchanged. Ordinary code upgrade/revert.

Validation

This branch is based directly on upstream main a97473b and contains one feature commit with no unmerged PR dependencies.

PASS: make fmt
PASS: cargo clippy --locked -p agentenv --all-targets --all-features -- -D warnings
PASS: cargo test --locked -p agentenv --lib orchestrator:: (150 tests)
PASS: cargo test --locked -p agentenv --lib sandbox::firecracker::mmds:: (6 tests)
PASS: temporary factory-boundary check of guest identity plus the existing host-metadata assertion
PASS: git diff --check

Rust checks ran on Linux as a non-root user. The temporary mock assertion was removed after validation and is not part of the commit. Full KVM/HTTP E2E was not run.

Risks and reviewer notes

The source change used a constructor; this port adapts it to the upstream struct initializer. The original author and author date are retained, with the original message followed by the existing co-author trailer for guozy18 covering the migration adaptation.

Checklist

One coherent change with no unrelated refactoring or formatting.
Original author attribution and author date are retained.
No private deployment configuration or credentials included.
Generated API files are unchanged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/AgentENV/pull/419 **Author:** [@guozy18](https://github.com/guozy18) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 10/23/2026 **Merged by:** [@yingdi-shan](https://github.com/yingdi-shan) **Base:** `main` ← **Head:** `sync/hide-guest-image-ref` --- ### 📝 Commits (1) - [`f6d25cc`](https://github.com/kvcache-ai/AgentENV/commit/f6d25cc1b9237e1b448b78ee847e2df49fe96a5d) fix(sandbox): hide image refs from guest metadata ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/orchestrator/service.rs` (+2 -1) </details> ### 📄 Description ## What Use "unknown" for the guest-visible envID of an image-based cold start while retaining the image reference in host-side sandbox metadata. ## Why Cold starts previously copied the source image reference into Firecracker MMDS, exposing registry/repository details to the guest. ## Related issue N/A — focused correction of existing behavior. ## Scope and non-goals The cold-start SandboxLaunchConfig initialization. ## Design and behavior changes Set only the guest launch identity to "unknown". Host metadata keeps its existing source image reference; snapshot-based launch identity continues to use the snapshot ID. ## Compatibility and operations Cold-start guests now see envID="unknown" instead of the source image reference. Host-facing metadata, API schema, persistent formats, configuration and dependencies are unchanged. Ordinary code upgrade/revert. ## Validation This branch is based directly on upstream main `a97473b` and contains one feature commit with no unmerged PR dependencies. ```text PASS: make fmt PASS: cargo clippy --locked -p agentenv --all-targets --all-features -- -D warnings PASS: cargo test --locked -p agentenv --lib orchestrator:: (150 tests) PASS: cargo test --locked -p agentenv --lib sandbox::firecracker::mmds:: (6 tests) PASS: temporary factory-boundary check of guest identity plus the existing host-metadata assertion PASS: git diff --check ``` Rust checks ran on Linux as a non-root user. The temporary mock assertion was removed after validation and is not part of the commit. Full KVM/HTTP E2E was not run. ## Risks and reviewer notes The source change used a constructor; this port adapts it to the upstream struct initializer. The original author and author date are retained, with the original message followed by the existing co-author trailer for guozy18 covering the migration adaptation. ## Checklist - [x] One coherent change with no unrelated refactoring or formatting. - [x] Original author attribution and author date are retained. - [x] No private deployment configuration or credentials included. - [x] Generated API files are unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:23:13 +00:00