mirror of
https://github.com/kvcache-ai/Mooncake.git
synced 2026-11-05 01:17:55 +00:00
[GH-ISSUE #4823] [Docs]: MC_GID_INDEX default is documented as 3, but the code default is automatic selection (-1) #1226
Labels
No labels
ascend
auto-closed
bug
bug
CI/Build
Common
documentation
enhancement
feature request
good first issue
help wanted
high priority
MetaX
nightly-failure
pull-request
PyTorch Backend
question
RFC
Roadmap
stale
Store
Tests
Transfer Engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
kvcache-ai/Mooncake#1226
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sivabreddy on GitHub (Oct 21, 2026).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/4823
Originally assigned to: @alogfans on GitHub.
docs/source/design/transfer-engine/index.md(line 473 onmainat7540f58) says:The code default is automatic selection:
int gid_index = -1; // -1 for auto-selectioninmooncake-transfer-engine/include/config.h, andconfig.cppreadsMC_GID_INDEX, thenNCCL_IB_GID_INDEXwhenMC_GID_INDEXis not set. The automatic selection inrdma_context.cppranks the GIDs and prefers one that has a network device.docs/source/zh_archive/run-examples.mdalso says the default is 3.Why it matters: on Kubernetes nodes where several pods share one RDMA device, the GID table holds entries for the interfaces of all pods on the node, so a fixed index (3, as the docs suggest) can pick another pod's GID. In our store-only test (4 clients, 2 per node, 16 keys of 4 MB each),
MC_GID_INDEX=3made 16 of 16 puts fail on every client, and automatic selection made 64 of 64 keys readable. We mentioned this in a comment on #4625; this issue tracks the docs change on its own.Suggested text:
We can send this as a docs PR if you prefer.
@github-actions[bot] commented on GitHub (Oct 21, 2026):
Thanks for opening this issue, @sivabreddy!
113816799A maintainer will triage this when possible. To help us respond faster, please include:
Useful links: Documentation · Contributing guide