[PR #18] [MERGED] [Bugfix] cpp std::string #1283

New issue

Closed

opened 2026-10-29 21:26:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/18
Author: @wxsms
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @stmatengss

Base: main ← Head: patch1

📝 Commits (4)

6bef568 fix: cpp std::string
cc54a56 Update dependencies.sh
4dac08e fix missing header file
be03d23 Merge pull request #1 from ruitard/patch2

📊 Changes

8 files changed (+8 additions, -7 deletions)

View changed files

📝 mooncake-transfer-engine/example/memory_pool.cpp (+1 -1)
📝 mooncake-transfer-engine/include/common.h (+1 -0)
📝 mooncake-transfer-engine/include/transfer_engine.h (+1 -1)
📝 mooncake-transfer-engine/include/transfer_metadata.h (+1 -1)
📝 mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h (+1 -1)
📝 mooncake-transfer-engine/include/transport/transport.h (+1 -1)
📝 mooncake-transfer-engine/src/transfer_metadata.cpp (+1 -1)
📝 mooncake-transfer-engine/src/transport/tcp_transport/tcp_transport.cpp (+1 -1)

📄 Description

add missing std:: to string, otherwise the build will failed.

my env:

cmake version 3.31.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).

gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/18 **Author:** [@wxsms](https://github.com/wxsms) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `patch1` --- ### 📝 Commits (4) - [`6bef568`](https://github.com/kvcache-ai/Mooncake/commit/6bef5685edf7f2a2c6206410cb23872aaa758bdc) fix: cpp std::string - [`cc54a56`](https://github.com/kvcache-ai/Mooncake/commit/cc54a566af663a521579ff94e5ec22b6d2a0ac10) Update dependencies.sh - [`4dac08e`](https://github.com/kvcache-ai/Mooncake/commit/4dac08edffbc5223ebc4cc9ba2d38f0c2ea6dbb8) fix missing header file - [`be03d23`](https://github.com/kvcache-ai/Mooncake/commit/be03d2338085b24a87b9d63b10d91cfff423869a) Merge pull request #1 from ruitard/patch2 ### 📊 Changes **8 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/example/memory_pool.cpp` (+1 -1) 📝 `mooncake-transfer-engine/include/common.h` (+1 -0) 📝 `mooncake-transfer-engine/include/transfer_engine.h` (+1 -1) 📝 `mooncake-transfer-engine/include/transfer_metadata.h` (+1 -1) 📝 `mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h` (+1 -1) 📝 `mooncake-transfer-engine/include/transport/transport.h` (+1 -1) 📝 `mooncake-transfer-engine/src/transfer_metadata.cpp` (+1 -1) 📝 `mooncake-transfer-engine/src/transport/tcp_transport/tcp_transport.cpp` (+1 -1) </details> ### 📄 Description add missing `std::` to string, otherwise the build will failed. my env: ``` cmake version 3.31.1 CMake suite maintained and supported by Kitware (kitware.com/cmake). ``` ``` gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 Copyright (C) 2021 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:01 +00:00