[PR #63] [MERGED] [TransferEngine] fix: improve error message #1305

New issue

Closed

opened 2026-10-29 21:26:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/63
Author: @doujiang24
Created: 1/6/2025
Status: ✅ Merged
Merged: 1/7/2025
Merged by: @alogfans

Base: main ← Head: log-error

📝 Commits (2)

ecfb9b0 [TransferEngine] fix: improve error message
1861ac5 use PLOG to print errno message.

📊 Changes

3 files changed (+78 additions, -82 deletions)

View changed files

📝 mooncake-transfer-engine/include/transport/rdma_transport/rdma_context.h (+3 -1)
📝 mooncake-transfer-engine/src/transport/rdma_transport/rdma_context.cpp (+60 -60)
📝 mooncake-transfer-engine/src/transport/rdma_transport/rdma_endpoint.cpp (+15 -21)

📄 Description

add strerror for methods which have errno
C++ will throw a std::bad_alloc execption when no memory, will add try catch in another PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/63 **Author:** [@doujiang24](https://github.com/doujiang24) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/7/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `log-error` --- ### 📝 Commits (2) - [`ecfb9b0`](https://github.com/kvcache-ai/Mooncake/commit/ecfb9b085d089bb1bbef94eeea2eda2d4fffaed1) [TransferEngine] fix: improve error message - [`1861ac5`](https://github.com/kvcache-ai/Mooncake/commit/1861ac5a03f9215110e8713daab4a096ca3cbe12) use PLOG to print errno message. ### 📊 Changes **3 files changed** (+78 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/include/transport/rdma_transport/rdma_context.h` (+3 -1) 📝 `mooncake-transfer-engine/src/transport/rdma_transport/rdma_context.cpp` (+60 -60) 📝 `mooncake-transfer-engine/src/transport/rdma_transport/rdma_endpoint.cpp` (+15 -21) </details> ### 📄 Description 1. add `strerror` for methods which have `errno` 2. C++ will throw a `std::bad_alloc` execption when no memory, will add try catch in another PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:13 +00:00