[PR #73] [MERGED] [TransferEngine] change: auto discover topology & install transport. #1310

New issue

Closed

opened 2026-10-29 21:26:16 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/73
Author: @doujiang24
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @ShangmingCai

Base: main ← Head: auto-discover

📝 Commits (6)

a92b639 [TransferEngine] change: auto discover topology & install transport.
69e7032 only install a single transport
7683324 improvements from @alogfans
594d518 keep old api in vllm-integration
6e5da52 p2pstore: keep backward api.
837c24b revert doc in v2.

📊 Changes

33 files changed (+221 additions, -295 deletions)

View changed files

📝 doc/en/p2p-store.md (+2 -5)
📝 doc/en/transfer-engine.md (+12 -58)
📝 doc/en/vllm-integration-v0.2.md (+1 -0)
📝 doc/zh/p2p-store.md (+1 -4)
📝 doc/zh/run-examples.md (+8 -0)
📝 doc/zh/transfer-engine.md (+9 -55)
📝 mooncake-integration/vllm/vllm_adaptor.cpp (+3 -2)
📝 mooncake-integration/vllm/vllm_adaptor.h (+6 -5)
📝 mooncake-p2p-store/src/example/p2p-store-example.go (+6 -24)
📝 mooncake-p2p-store/src/p2pstore/core.go (+3 -3)
📝 mooncake-p2p-store/src/p2pstore/transfer_engine.go (+26 -16)
📝 mooncake-transfer-engine/example/memory_pool.cpp (+2 -1)
📝 mooncake-transfer-engine/example/transfer_engine_bench.cpp (+34 -27)
📝 mooncake-transfer-engine/include/multi_transport.h (+2 -1)
📝 mooncake-transfer-engine/include/transfer_engine.h (+10 -3)
📝 mooncake-transfer-engine/include/transport/cxl_transport/cxl_transport.h (+4 -3)
📝 mooncake-transfer-engine/include/transport/nvmeof_transport/nvmeof_transport.h (+4 -3)
📝 mooncake-transfer-engine/include/transport/rdma_transport/rdma_transport.h (+3 -2)
📝 mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h (+5 -3)
📝 mooncake-transfer-engine/include/transport/transport.h (+2 -1)

...and 13 more files

📄 Description

allow TransferEngine(false) to disable auto discover, for internal testing.
users do not need to install transport manually.
will update kvcache-ai/vllm after this PR merged, since VLLMAdaptor is changed.

fix #69

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/73 **Author:** [@doujiang24](https://github.com/doujiang24) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@ShangmingCai](https://github.com/ShangmingCai) **Base:** `main` ← **Head:** `auto-discover` --- ### 📝 Commits (6) - [`a92b639`](https://github.com/kvcache-ai/Mooncake/commit/a92b639795e631b21a54151f07f5cd811184a7d4) [TransferEngine] change: auto discover topology & install transport. - [`69e7032`](https://github.com/kvcache-ai/Mooncake/commit/69e7032922c886a8a16b01966cabb1a42298d485) only install a single transport - [`7683324`](https://github.com/kvcache-ai/Mooncake/commit/7683324d545b3b040c0d697429998bda3efc8694) improvements from @alogfans - [`594d518`](https://github.com/kvcache-ai/Mooncake/commit/594d518c0f13d7789ae3cd3236d77350353b21ba) keep old api in vllm-integration - [`6e5da52`](https://github.com/kvcache-ai/Mooncake/commit/6e5da528ee434c5a93bb5622ff5eca1c2c102ea5) p2pstore: keep backward api. - [`837c24b`](https://github.com/kvcache-ai/Mooncake/commit/837c24be8febf8b477ec2c8c04dc983a3692b243) revert doc in v2. ### 📊 Changes **33 files changed** (+221 additions, -295 deletions) <details> <summary>View changed files</summary> 📝 `doc/en/p2p-store.md` (+2 -5) 📝 `doc/en/transfer-engine.md` (+12 -58) 📝 `doc/en/vllm-integration-v0.2.md` (+1 -0) 📝 `doc/zh/p2p-store.md` (+1 -4) 📝 `doc/zh/run-examples.md` (+8 -0) 📝 `doc/zh/transfer-engine.md` (+9 -55) 📝 `mooncake-integration/vllm/vllm_adaptor.cpp` (+3 -2) 📝 `mooncake-integration/vllm/vllm_adaptor.h` (+6 -5) 📝 `mooncake-p2p-store/src/example/p2p-store-example.go` (+6 -24) 📝 `mooncake-p2p-store/src/p2pstore/core.go` (+3 -3) 📝 `mooncake-p2p-store/src/p2pstore/transfer_engine.go` (+26 -16) 📝 `mooncake-transfer-engine/example/memory_pool.cpp` (+2 -1) 📝 `mooncake-transfer-engine/example/transfer_engine_bench.cpp` (+34 -27) 📝 `mooncake-transfer-engine/include/multi_transport.h` (+2 -1) 📝 `mooncake-transfer-engine/include/transfer_engine.h` (+10 -3) 📝 `mooncake-transfer-engine/include/transport/cxl_transport/cxl_transport.h` (+4 -3) 📝 `mooncake-transfer-engine/include/transport/nvmeof_transport/nvmeof_transport.h` (+4 -3) 📝 `mooncake-transfer-engine/include/transport/rdma_transport/rdma_transport.h` (+3 -2) 📝 `mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h` (+5 -3) 📝 `mooncake-transfer-engine/include/transport/transport.h` (+2 -1) _...and 13 more files_ </details> ### 📄 Description 1. allow `TransferEngine(false)` to disable auto discover, for internal testing. 2. users do not need to install transport manually. 3. will update `kvcache-ai/vllm` after this PR merged, since `VLLMAdaptor` is changed. fix #69 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:16 +00:00