[PR #79] [MERGED] [TransferEngine] Correct the count of slice_quque_ in rdma/worker_pool, remove the repeated check for overlap #1313

New issue

Closed

opened 2026-10-29 21:26:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/79
Author: @fengquyoumo
Created: 1/13/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @alogfans

Base: main ← Head: code_opt

📝 Commits (2)

d7cf77e correct the count of slice_queue_, although it has no adverse effects
4fd4b67 The overlap check in rdma_transport is repeat with checkOverlap in TransferEngine::registerLocalMemory which is better

📊 Changes

2 files changed (+1 additions, -23 deletions)

View changed files

📝 mooncake-transfer-engine/src/transport/rdma_transport/rdma_context.cpp (+0 -22)
📝 mooncake-transfer-engine/src/transport/rdma_transport/worker_pool.cpp (+1 -1)

📄 Description

Correct the count of slice_queue_, although it has no adverse effects
The overlap check in rdma_transport is repeat with checkOverlap in TransferEngine::registerLocalMemory which is better

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/79 **Author:** [@fengquyoumo](https://github.com/fengquyoumo) **Created:** 1/13/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `code_opt` --- ### 📝 Commits (2) - [`d7cf77e`](https://github.com/kvcache-ai/Mooncake/commit/d7cf77e229c28024d6c83e405d7356309ef93b77) correct the count of slice_queue_, although it has no adverse effects - [`4fd4b67`](https://github.com/kvcache-ai/Mooncake/commit/4fd4b67f0a6b9ab715fc6140d704b6b5a6a66bf7) The overlap check in rdma_transport is repeat with checkOverlap in TransferEngine::registerLocalMemory which is better ### 📊 Changes **2 files changed** (+1 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/src/transport/rdma_transport/rdma_context.cpp` (+0 -22) 📝 `mooncake-transfer-engine/src/transport/rdma_transport/worker_pool.cpp` (+1 -1) </details> ### 📄 Description 1. Correct the count of slice_queue_, although it has no adverse effects 2. The overlap check in rdma_transport is repeat with checkOverlap in TransferEngine::registerLocalMemory which is better --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:17 +00:00