[PR #80] [MERGED] Fix P2P store bugs and improvement #1314

New issue

Closed

opened 2026-10-29 21:26:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/80
Author: @alogfans
Created: 1/14/2025
Status: ✅ Merged
Merged: 2/17/2025
Merged by: @ShangmingCai

Base: main ← Head: fix-p2p-store

📝 Commits (8)

683e75f fix: make golang interface consistent with C APIs
f2a28a8 check data integrity after getting replica
2623b32 work around to terminate timeout transfer request
8c65466 avoid unncessary metadata cache invalidate
9a1aa2e Merge branch 'main' into fix-p2p-store
8efca69 disable auto discover by default
2b97524 revert to legacy topology format
2c2b2fd Merge remote-tracking branch 'origin/main' into fix-p2p-store

📊 Changes

12 files changed (+305 additions, -179 deletions)

View changed files

📝 mooncake-p2p-store/build.sh (+14 -6)
📝 mooncake-p2p-store/src/example/p2p-store-example.go (+63 -23)
📝 mooncake-p2p-store/src/p2pstore/core.go (+143 -63)
📝 mooncake-p2p-store/src/p2pstore/metadata.go (+7 -3)
📝 mooncake-p2p-store/src/p2pstore/registered_memory.go (+1 -1)
📝 mooncake-p2p-store/src/p2pstore/transfer_engine.go (+54 -76)
📝 mooncake-transfer-engine/include/transfer_engine.h (+4 -2)
📝 mooncake-transfer-engine/include/transfer_engine_c.h (+2 -0)
📝 mooncake-transfer-engine/include/transfer_metadata.h (+1 -1)
📝 mooncake-transfer-engine/src/topology.cpp (+1 -1)
📝 mooncake-transfer-engine/src/transfer_engine_c.cpp (+7 -0)
📝 mooncake-transfer-engine/src/transfer_metadata.cpp (+8 -3)

📄 Description

I have refactor the code in mooncake-p2p-store/src/p2pstore/transfer_engine.go so that the Go wrapper is consistent with new C APIs. I also move ldflags option to build script.
Fix bugs to keep data integrity after deleting replica nodes
Ensure transfer timeout
Cache invalidation only in neccessary

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/80 **Author:** [@alogfans](https://github.com/alogfans) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@ShangmingCai](https://github.com/ShangmingCai) **Base:** `main` ← **Head:** `fix-p2p-store` --- ### 📝 Commits (8) - [`683e75f`](https://github.com/kvcache-ai/Mooncake/commit/683e75fc6243603cbfeaab2f33fc6fcef5e2f467) fix: make golang interface consistent with C APIs - [`f2a28a8`](https://github.com/kvcache-ai/Mooncake/commit/f2a28a81cfb5b7110abe6f6df7e995eec3c3f1e9) check data integrity after getting replica - [`2623b32`](https://github.com/kvcache-ai/Mooncake/commit/2623b32689d494b142334f1cca61bae7ff5b5b59) work around to terminate timeout transfer request - [`8c65466`](https://github.com/kvcache-ai/Mooncake/commit/8c65466bebe2992b82d64162d4b91f9acecf0252) avoid unncessary metadata cache invalidate - [`9a1aa2e`](https://github.com/kvcache-ai/Mooncake/commit/9a1aa2e3ba29f7abcfd84086589359ce85a8b490) Merge branch 'main' into fix-p2p-store - [`8efca69`](https://github.com/kvcache-ai/Mooncake/commit/8efca698ec70de002fe7511674dbf0fb0f3607d2) disable auto discover by default - [`2b97524`](https://github.com/kvcache-ai/Mooncake/commit/2b97524bf7e3bbe8c90eb2249cdcb15af4c63e77) revert to legacy topology format - [`2c2b2fd`](https://github.com/kvcache-ai/Mooncake/commit/2c2b2fda83d62f086ae4155b1a4a434b33e56872) Merge remote-tracking branch 'origin/main' into fix-p2p-store ### 📊 Changes **12 files changed** (+305 additions, -179 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-p2p-store/build.sh` (+14 -6) 📝 `mooncake-p2p-store/src/example/p2p-store-example.go` (+63 -23) 📝 `mooncake-p2p-store/src/p2pstore/core.go` (+143 -63) 📝 `mooncake-p2p-store/src/p2pstore/metadata.go` (+7 -3) 📝 `mooncake-p2p-store/src/p2pstore/registered_memory.go` (+1 -1) 📝 `mooncake-p2p-store/src/p2pstore/transfer_engine.go` (+54 -76) 📝 `mooncake-transfer-engine/include/transfer_engine.h` (+4 -2) 📝 `mooncake-transfer-engine/include/transfer_engine_c.h` (+2 -0) 📝 `mooncake-transfer-engine/include/transfer_metadata.h` (+1 -1) 📝 `mooncake-transfer-engine/src/topology.cpp` (+1 -1) 📝 `mooncake-transfer-engine/src/transfer_engine_c.cpp` (+7 -0) 📝 `mooncake-transfer-engine/src/transfer_metadata.cpp` (+8 -3) </details> ### 📄 Description - I have refactor the code in `mooncake-p2p-store/src/p2pstore/transfer_engine.go` so that the Go wrapper is consistent with new C APIs. I also move ldflags option to build script. - Fix bugs to keep data integrity after deleting replica nodes - Ensure transfer timeout - Cache invalidation only in neccessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:17 +00:00