[PR #91] [CLOSED] xx #1319

New issue

Closed

opened 2026-10-29 21:26:20 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/91
Author: @RuixiangMa
Created: 1/23/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (4)

bc05fdf [TransferEngine]chore: replace slices vector with slice counter
7ee9401 Merge branch 'kvcache-ai:main' into main
dfd9974 [TransferEngine]fix: Replace raw 'new' with 'std::make_unique' for safer memory management
3bfeb10 Merge remote-tracking branch 'refs/remotes/origin/main'

📊 Changes

6 files changed (+71 additions, -32 deletions)

View changed files

📝 mooncake-transfer-engine/include/transport/rdma_transport/worker_pool.h (+1 -1)
📝 mooncake-transfer-engine/include/transport/transport.h (+2 -5)
📝 mooncake-transfer-engine/src/multi_transport.cpp (+1 -1)
📝 mooncake-transfer-engine/src/transport/nvmeof_transport/nvmeof_transport.cpp (+22 -12)
📝 mooncake-transfer-engine/src/transport/rdma_transport/rdma_transport.cpp (+24 -8)
📝 mooncake-transfer-engine/src/transport/tcp_transport/tcp_transport.cpp (+21 -5)

📄 Description

Since the slices are solely utilized for counting purposes, replace them with counters to eliminate memory overhead
add exception handling and memory safety

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/91 **Author:** [@RuixiangMa](https://github.com/RuixiangMa) **Created:** 1/23/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`bc05fdf`](https://github.com/kvcache-ai/Mooncake/commit/bc05fdf97950239873796babd7696a148fc74ee5) [TransferEngine]chore: replace slices vector with slice counter - [`7ee9401`](https://github.com/kvcache-ai/Mooncake/commit/7ee9401085b4f7e33ad8b583f49f91dcef4964d1) Merge branch 'kvcache-ai:main' into main - [`dfd9974`](https://github.com/kvcache-ai/Mooncake/commit/dfd9974065076c3d847be027f99070daa6838bf7) [TransferEngine]fix: Replace raw 'new' with 'std::make_unique' for safer memory management - [`3bfeb10`](https://github.com/kvcache-ai/Mooncake/commit/3bfeb10e1d0bc957e86b2149901584b90a2ecc34) Merge remote-tracking branch 'refs/remotes/origin/main' ### 📊 Changes **6 files changed** (+71 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/include/transport/rdma_transport/worker_pool.h` (+1 -1) 📝 `mooncake-transfer-engine/include/transport/transport.h` (+2 -5) 📝 `mooncake-transfer-engine/src/multi_transport.cpp` (+1 -1) 📝 `mooncake-transfer-engine/src/transport/nvmeof_transport/nvmeof_transport.cpp` (+22 -12) 📝 `mooncake-transfer-engine/src/transport/rdma_transport/rdma_transport.cpp` (+24 -8) 📝 `mooncake-transfer-engine/src/transport/tcp_transport/tcp_transport.cpp` (+21 -5) </details> ### 📄 Description 1. Since the slices are solely utilized for counting purposes, replace them with counters to eliminate memory overhead 2. add exception handling and memory safety --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:20 +00:00