[PR #94] [MERGED] [Transfer Engine] add USE_ETCD option to retire the etcd dependency. #1320

New issue

Closed

opened 2026-10-29 21:26:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/94
Author: @doujiang24
Created: 1/26/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @alogfans

Base: main ← Head: no-etcd

📝 Commits (2)

e2c10d8 [Transfer Engine] add USE_ETCD option to retire the etcd dependency.
6c2addf make sure at least one metadata.

📊 Changes

5 files changed (+37 additions, -15 deletions)

View changed files

📝 CMakeLists.txt (+10 -0)
📝 mooncake-transfer-engine/include/topology.h (+1 -2)
📝 mooncake-transfer-engine/include/transfer_metadata.h (+0 -1)
📝 mooncake-transfer-engine/src/CMakeLists.txt (+6 -4)
📝 mooncake-transfer-engine/src/transfer_metadata_plugin.cpp (+20 -8)

📄 Description

Keep etcd enabled as default, since USE_ETCD default to ON, but allow people to disable it by USE_ETCD=OFF, so that the dependency could be a little simpler.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/94 **Author:** [@doujiang24](https://github.com/doujiang24) **Created:** 1/26/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `no-etcd` --- ### 📝 Commits (2) - [`e2c10d8`](https://github.com/kvcache-ai/Mooncake/commit/e2c10d8b0c0e1bdd6609ee0b97cdd0c0ecfb3c00) [Transfer Engine] add USE_ETCD option to retire the etcd dependency. - [`6c2addf`](https://github.com/kvcache-ai/Mooncake/commit/6c2addf457b7b4fa1a7c63a5039a578060bd04d3) make sure at least one metadata. ### 📊 Changes **5 files changed** (+37 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+10 -0) 📝 `mooncake-transfer-engine/include/topology.h` (+1 -2) 📝 `mooncake-transfer-engine/include/transfer_metadata.h` (+0 -1) 📝 `mooncake-transfer-engine/src/CMakeLists.txt` (+6 -4) 📝 `mooncake-transfer-engine/src/transfer_metadata_plugin.cpp` (+20 -8) </details> ### 📄 Description Keep etcd enabled as default, since `USE_ETCD` default to `ON`, but allow people to disable it by `USE_ETCD=OFF`, so that the dependency could be a little simpler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:21 +00:00