[PR #149] [CLOSED] [FEATURE] Support mounting multiple segments under the same segment_name #1355

New issue

Closed

opened 2026-10-29 21:26:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/149
Author: @xiaguan
Created: 3/18/2025
Status: ❌ Closed

Base: main ← Head: multiple_segment

📝 Commits (2)

cea6731 [FEATURE] Update MooncakeStroe CI workflow
06b3e8f [FEATURE] Support mounting multiple segments under the same segment_name.

📊 Changes

15 files changed (+258 additions, -84 deletions)

View changed files

📝 .github/workflows/build-linux.yml (+12 -1)
📝 doc/en/mooncake-store-preview.md (+6 -3)
📝 doc/zh/mooncake-store-preview.md (+6 -3)
📝 mooncake-integration/vllm/distributed_object_store.cpp (+4 -4)
📝 mooncake-store/include/allocation_strategy.h (+30 -6)
📝 mooncake-store/include/client.h (+3 -1)
📝 mooncake-store/include/master_service.h (+11 -7)
📝 mooncake-store/proto/master.proto (+1 -0)
📝 mooncake-store/src/client.cpp (+17 -10)
📝 mooncake-store/src/master.cpp (+9 -4)
📝 mooncake-store/src/master_service.cpp (+37 -18)
📝 mooncake-store/tests/CMakeLists.txt (+3 -1)
📝 mooncake-store/tests/client_integration_test.cpp (+40 -17)
📝 mooncake-store/tests/master_service_test.cpp (+15 -7)
📝 mooncake-store/tests/test_distributed_object_store.py (+64 -2)

📄 Description

Supported mounting multiple segments for the same client.

Taking it a step further, we might consider modifying the segment management interface on the client side, such as removing the segment_name parameter from the interface (since the segment name is fixed once the client is inited).

Going even further, the client should ideally be stateless, and perhaps MountSegment should return a handle whose ownership is managed by the user.

To keep this PR concise, the discussions will not be implemented in this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/149 **Author:** [@xiaguan](https://github.com/xiaguan) **Created:** 3/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `multiple_segment` --- ### 📝 Commits (2) - [`cea6731`](https://github.com/kvcache-ai/Mooncake/commit/cea6731ece5ad470b4c21c300dfe521a11b40b08) [FEATURE] Update MooncakeStroe CI workflow - [`06b3e8f`](https://github.com/kvcache-ai/Mooncake/commit/06b3e8f92c2c78090482eb5aa6106dcfc0ad86af) [FEATURE] Support mounting multiple segments under the same segment_name. ### 📊 Changes **15 files changed** (+258 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-linux.yml` (+12 -1) 📝 `doc/en/mooncake-store-preview.md` (+6 -3) 📝 `doc/zh/mooncake-store-preview.md` (+6 -3) 📝 `mooncake-integration/vllm/distributed_object_store.cpp` (+4 -4) 📝 `mooncake-store/include/allocation_strategy.h` (+30 -6) 📝 `mooncake-store/include/client.h` (+3 -1) 📝 `mooncake-store/include/master_service.h` (+11 -7) 📝 `mooncake-store/proto/master.proto` (+1 -0) 📝 `mooncake-store/src/client.cpp` (+17 -10) 📝 `mooncake-store/src/master.cpp` (+9 -4) 📝 `mooncake-store/src/master_service.cpp` (+37 -18) 📝 `mooncake-store/tests/CMakeLists.txt` (+3 -1) 📝 `mooncake-store/tests/client_integration_test.cpp` (+40 -17) 📝 `mooncake-store/tests/master_service_test.cpp` (+15 -7) 📝 `mooncake-store/tests/test_distributed_object_store.py` (+64 -2) </details> ### 📄 Description Supported mounting multiple segments for the same client. Taking it a step further, we might consider modifying the segment management interface on the client side, such as removing the `segment_name` parameter from the interface (since the segment name is fixed once the client is inited). Going even further, the client should ideally be stateless, and perhaps `MountSegment` should return a handle whose ownership is managed by the user. To keep this PR concise, the discussions will not be implemented in this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:43 +00:00