[PR #161] [CLOSED] [TransferEngine] Refactor TE Return Value - part 2 #1363

New issue

Closed

opened 2026-10-29 21:26:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:26:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/161
Author: @yuan-luo
Created: 3/21/2025
Status: ❌ Closed

Base: main ← Head: refactor_ret_val_part2

📝 Commits (1)

daea9f6 Support Status return value - part 2

📊 Changes

36 files changed (+702 additions, -548 deletions)

View changed files

📝 mooncake-integration/vllm/vllm_adaptor.cpp (+13 -9)
📝 mooncake-store/src/client.cpp (+15 -13)
📝 mooncake-transfer-engine/example/memory_pool.cpp (+2 -2)
📝 mooncake-transfer-engine/example/transfer_engine_bench.cpp (+4 -4)
📝 mooncake-transfer-engine/include/topology.h (+3 -1)
📝 mooncake-transfer-engine/include/transfer_engine.h (+12 -12)
📝 mooncake-transfer-engine/include/transfer_metadata.h (+19 -16)
📝 mooncake-transfer-engine/include/transfer_metadata_plugin.h (+5 -5)
📝 mooncake-transfer-engine/include/transport/cxl_transport/cxl_transport.h (+13 -12)
📝 mooncake-transfer-engine/include/transport/nvmeof_transport/nvmeof_transport.h (+13 -12)
📝 mooncake-transfer-engine/include/transport/rdma_transport/rdma_context.h (+9 -9)
📝 mooncake-transfer-engine/include/transport/rdma_transport/rdma_endpoint.h (+16 -16)
📝 mooncake-transfer-engine/include/transport/rdma_transport/rdma_transport.h (+24 -21)
📝 mooncake-transfer-engine/include/transport/rdma_transport/worker_pool.h (+1 -1)
📝 mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h (+11 -10)
📝 mooncake-transfer-engine/include/transport/transport.h (+11 -11)
📝 mooncake-transfer-engine/rust/src/transfer_engine.rs (+4 -4)
📝 mooncake-transfer-engine/src/multi_transport.cpp (+2 -1)
📝 mooncake-transfer-engine/src/topology.cpp (+19 -10)
📝 mooncake-transfer-engine/src/transfer_engine.cpp (+30 -29)

...and 16 more files

📄 Description

This PR refactors most functions within the TransferEngine to use more descriptive and structured return types (e.g., Status, StatusOr), replacing ambiguous or less informative return values such as int, bool, or void.

This is a follow up PR of PR125. The motivations are as follows:

Improve code readability and maintainability
Enable better error propagation and diagnostics
Make debugging easier by providing explicit error messages and context

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/161 **Author:** [@yuan-luo](https://github.com/yuan-luo) **Created:** 3/21/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor_ret_val_part2` --- ### 📝 Commits (1) - [`daea9f6`](https://github.com/kvcache-ai/Mooncake/commit/daea9f6d7c1e0d800163e6695d23d236a7fe616e) Support Status return value - part 2 ### 📊 Changes **36 files changed** (+702 additions, -548 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-integration/vllm/vllm_adaptor.cpp` (+13 -9) 📝 `mooncake-store/src/client.cpp` (+15 -13) 📝 `mooncake-transfer-engine/example/memory_pool.cpp` (+2 -2) 📝 `mooncake-transfer-engine/example/transfer_engine_bench.cpp` (+4 -4) 📝 `mooncake-transfer-engine/include/topology.h` (+3 -1) 📝 `mooncake-transfer-engine/include/transfer_engine.h` (+12 -12) 📝 `mooncake-transfer-engine/include/transfer_metadata.h` (+19 -16) 📝 `mooncake-transfer-engine/include/transfer_metadata_plugin.h` (+5 -5) 📝 `mooncake-transfer-engine/include/transport/cxl_transport/cxl_transport.h` (+13 -12) 📝 `mooncake-transfer-engine/include/transport/nvmeof_transport/nvmeof_transport.h` (+13 -12) 📝 `mooncake-transfer-engine/include/transport/rdma_transport/rdma_context.h` (+9 -9) 📝 `mooncake-transfer-engine/include/transport/rdma_transport/rdma_endpoint.h` (+16 -16) 📝 `mooncake-transfer-engine/include/transport/rdma_transport/rdma_transport.h` (+24 -21) 📝 `mooncake-transfer-engine/include/transport/rdma_transport/worker_pool.h` (+1 -1) 📝 `mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h` (+11 -10) 📝 `mooncake-transfer-engine/include/transport/transport.h` (+11 -11) 📝 `mooncake-transfer-engine/rust/src/transfer_engine.rs` (+4 -4) 📝 `mooncake-transfer-engine/src/multi_transport.cpp` (+2 -1) 📝 `mooncake-transfer-engine/src/topology.cpp` (+19 -10) 📝 `mooncake-transfer-engine/src/transfer_engine.cpp` (+30 -29) _...and 16 more files_ </details> ### 📄 Description This PR refactors most functions within the TransferEngine to use more descriptive and structured return types (e.g., Status, StatusOr<T>), replacing ambiguous or less informative return values such as int, bool, or void. This is a follow up PR of [PR125](https://github.com/kvcache-ai/Mooncake/pull/125). The **motivations** are as follows: - Improve code readability and maintainability - Enable better error propagation and diagnostics - Make debugging easier by providing explicit error messages and context --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:26:46 +00:00