[PR #365] [MERGED] [BugFix] Buffer Allocation Always Tries on the Same Allocator #1515

New issue

Closed

opened 2026-10-29 21:28:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:28:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/365
Author: @ykwd
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/15/2025
Merged by: @alogfans

Base: main ← Head: bugfix/random_allocate

📝 Commits (1)

ebcfe67 [BugFix] In buffer allocation, multiple randomly trying strategy doesn't work as expected.

📊 Changes

1 file changed (+12 additions, -7 deletions)

View changed files

📝 mooncake-store/include/allocation_strategy.h (+12 -7)

📄 Description

In buffer allocation, when there are multiple eligible allocators, it will randomly select one and use it to try to allocate the buffer. This process will iterate many times, but each time the program will only try a specific one, instead of trying other eligible allocators. This pr fixex this issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/365 **Author:** [@ykwd](https://github.com/ykwd) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/15/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `bugfix/random_allocate` --- ### 📝 Commits (1) - [`ebcfe67`](https://github.com/kvcache-ai/Mooncake/commit/ebcfe673cccaf13bccb40dbc3b25bea1e1da16a4) [BugFix] In buffer allocation, multiple randomly trying strategy doesn't work as expected. ### 📊 Changes **1 file changed** (+12 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/allocation_strategy.h` (+12 -7) </details> ### 📄 Description In buffer allocation, when there are multiple eligible allocators, it will randomly select one and use it to try to allocate the buffer. This process will iterate many times, but each time the program will only try a specific one, instead of trying other eligible allocators. This pr fixex this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:28:07 +00:00