[PR #408] [MERGED] [Fix] Store Metrics-related Bugs #1549

New issue

Closed

opened 2026-10-29 21:28:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:28:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/408
Author: @ykwd
Created: 5/26/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @xiaguan

Base: main ← Head: feature/eviction_metrics

📝 Commits (3)

b72ff91 Add eviction related metrics to metrics output;
7df7edc Change metrics value type from double to int64_t
464f05b For MasterMetricManager: add getter functions and basic unit tests

📊 Changes

6 files changed (+422 additions, -103 deletions)

View changed files

📝 mooncake-store/include/master_metric_manager.h (+78 -49)
📝 mooncake-store/src/allocator.cpp (+1 -0)
📝 mooncake-store/src/master_metric_manager.cpp (+167 -53)
📝 mooncake-store/src/master_service.cpp (+1 -1)
📝 mooncake-store/tests/CMakeLists.txt (+11 -0)
➕ mooncake-store/tests/master_metrics_test.cpp (+164 -0)

📄 Description

The eviction-related metrics are calculated but do not add to the output string.
When unmounting a segment, keys are removed, but the corresponding metrics do not change.
Adjust the position of some eviction metrics code blocks to make code ordering consistent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/408 **Author:** [@ykwd](https://github.com/ykwd) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@xiaguan](https://github.com/xiaguan) **Base:** `main` ← **Head:** `feature/eviction_metrics` --- ### 📝 Commits (3) - [`b72ff91`](https://github.com/kvcache-ai/Mooncake/commit/b72ff91343ae57cd85a0fb5c755d6b0d310ae8f8) Add eviction related metrics to metrics output; - [`7df7edc`](https://github.com/kvcache-ai/Mooncake/commit/7df7edcd23057438c16c8c3071bf1d61832f125d) Change metrics value type from double to int64_t - [`464f05b`](https://github.com/kvcache-ai/Mooncake/commit/464f05bf8718055d961c6d73646a8f36db5dfe54) For MasterMetricManager: add getter functions and basic unit tests ### 📊 Changes **6 files changed** (+422 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/master_metric_manager.h` (+78 -49) 📝 `mooncake-store/src/allocator.cpp` (+1 -0) 📝 `mooncake-store/src/master_metric_manager.cpp` (+167 -53) 📝 `mooncake-store/src/master_service.cpp` (+1 -1) 📝 `mooncake-store/tests/CMakeLists.txt` (+11 -0) ➕ `mooncake-store/tests/master_metrics_test.cpp` (+164 -0) </details> ### 📄 Description 1. The eviction-related metrics are calculated but do not add to the output string. 2. When unmounting a segment, keys are removed, but the corresponding metrics do not change. 3. Adjust the position of some eviction metrics code blocks to make code ordering consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:28:21 +00:00