[PR #582] [MERGED] mooncake-common: add config class #1668

New issue

Closed

opened 2026-10-29 21:29:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:29:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/582
Author: @201341
Created: 7/2/2025
Status: ✅ Merged
Merged: 7/21/2025
Merged by: @ykwd

Base: main ← Head: swj/config

📝 Commits (5)

df11c1b mooncake-common: add common config class
0ac354f fix comments
0201f17 support json format
cc4ffad add unit tests
e448824 fix comments

📊 Changes

11 files changed (+485 additions, -1 deletions)

View changed files

📝 CMakeLists.txt (+1 -0)
📝 dependencies.sh (+1 -0)
📝 mooncake-common/CMakeLists.txt (+8 -1)
📝 mooncake-common/common.cmake (+1 -0)
➕ mooncake-common/include/default_config.h (+134 -0)
➕ mooncake-common/src/CMakeLists.txt (+13 -0)
➕ mooncake-common/src/default_config.cpp (+214 -0)
➕ mooncake-common/tests/CMakeLists.txt (+6 -0)
➕ mooncake-common/tests/default_config_test.cpp (+90 -0)
➕ mooncake-common/tests/test.json (+10 -0)
➕ mooncake-common/tests/test.yaml (+7 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/582 **Author:** [@201341](https://github.com/201341) **Created:** 7/2/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@ykwd](https://github.com/ykwd) **Base:** `main` ← **Head:** `swj/config` --- ### 📝 Commits (5) - [`df11c1b`](https://github.com/kvcache-ai/Mooncake/commit/df11c1be207ff537772007694f5a878625f79c5c) mooncake-common: add common config class - [`0ac354f`](https://github.com/kvcache-ai/Mooncake/commit/0ac354fc51bb15b39b67f75bfc97de95fb5376e7) fix comments - [`0201f17`](https://github.com/kvcache-ai/Mooncake/commit/0201f1770c9f09e06ab63f9f5860db56e1daecab) support json format - [`cc4ffad`](https://github.com/kvcache-ai/Mooncake/commit/cc4ffad267b5c5434e76e410fc885e04300c6041) add unit tests - [`e448824`](https://github.com/kvcache-ai/Mooncake/commit/e44882474ef4607459f6fa73cf859197cf272320) fix comments ### 📊 Changes **11 files changed** (+485 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -0) 📝 `dependencies.sh` (+1 -0) 📝 `mooncake-common/CMakeLists.txt` (+8 -1) 📝 `mooncake-common/common.cmake` (+1 -0) ➕ `mooncake-common/include/default_config.h` (+134 -0) ➕ `mooncake-common/src/CMakeLists.txt` (+13 -0) ➕ `mooncake-common/src/default_config.cpp` (+214 -0) ➕ `mooncake-common/tests/CMakeLists.txt` (+6 -0) ➕ `mooncake-common/tests/default_config_test.cpp` (+90 -0) ➕ `mooncake-common/tests/test.json` (+10 -0) ➕ `mooncake-common/tests/test.yaml` (+7 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:29:21 +00:00