[PR #588] [MERGED] test(client): add batch put test for duplicate keys #1670

New issue

Closed

opened 2026-10-29 21:29:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:29:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/588
Author: @xiaguan
Created: 7/3/2025
Status: ✅ Merged
Merged: 7/9/2025
Merged by: @xiaguan

Base: main ← Head: batch_put_same_key

📝 Commits (2)

2921e30 test(client): add batch put test for duplicate keys
291c5c2 fix typo

📊 Changes

3 files changed (+77 additions, -17 deletions)

View changed files

📝 mooncake-store/include/types.h (+22 -16)
📝 mooncake-store/src/client.cpp (+4 -1)
📝 mooncake-store/tests/client_integration_test.cpp (+51 -0)

📄 Description

Removed the CHECK on master to avoid a crash, and added a test to cover this case.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/588 **Author:** [@xiaguan](https://github.com/xiaguan) **Created:** 7/3/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@xiaguan](https://github.com/xiaguan) **Base:** `main` ← **Head:** `batch_put_same_key` --- ### 📝 Commits (2) - [`2921e30`](https://github.com/kvcache-ai/Mooncake/commit/2921e304f29340d178f22c831c87a0c4388f344c) test(client): add batch put test for duplicate keys - [`291c5c2`](https://github.com/kvcache-ai/Mooncake/commit/291c5c21583a36824be8840a2c695bd8751eb1a6) fix typo ### 📊 Changes **3 files changed** (+77 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/types.h` (+22 -16) 📝 `mooncake-store/src/client.cpp` (+4 -1) 📝 `mooncake-store/tests/client_integration_test.cpp` (+51 -0) </details> ### 📄 Description Removed the CHECK on master to avoid a crash, and added a test to cover this case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:29:22 +00:00