[PR #760] [MERGED] [Store] Serialize/Deserialize Offset Allocator #1802

New issue

Closed

opened 2026-10-29 21:30:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/760
Author: @ykwd
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @ykwd

Base: main ← Head: dev/allocator-serialization

📝 Commits (10+)

25b4958 Basic implementation
cd82ad5 Fix bugs; Add unit tests
4d49708 Enhance unit tests
4bb1d0d Enhance unit tests
a87e463 revert unnecessary changes
c1d95e4 Enhance unit test
b614f19 Minor changes
acc5f10 Update unit test
cbeb7f6 Avoid too many error log
5ae3729 Add comments

📊 Changes

7 files changed (+1196 additions, -98 deletions)

View changed files

📝 mooncake-store/include/offset_allocator/offset_allocator.hpp (+123 -4)
➕ mooncake-store/include/serializer.h (+377 -0)
📝 mooncake-store/include/types.h (+4 -0)
📝 mooncake-store/tests/CMakeLists.txt (+11 -0)
📝 mooncake-store/tests/master_metrics_test.cpp (+0 -4)
📝 mooncake-store/tests/offset_allocator_test.cpp (+508 -90)
➕ mooncake-store/tests/serializer_test.cpp (+173 -0)

📄 Description

This feature will be used for persisting master KV metadata. The serialize and deserialize methods of OffsetAllocator are implemented as templates; otherwise, offset_allocator.h would need to directly or indirectly include type.h, which would result in circular dependencies and compilation failure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/760 **Author:** [@ykwd](https://github.com/ykwd) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@ykwd](https://github.com/ykwd) **Base:** `main` ← **Head:** `dev/allocator-serialization` --- ### 📝 Commits (10+) - [`25b4958`](https://github.com/kvcache-ai/Mooncake/commit/25b495814ee5b84a1f4f94baf03974931e6341e3) Basic implementation - [`cd82ad5`](https://github.com/kvcache-ai/Mooncake/commit/cd82ad5de647c2786e7fb86755247b49fd20fe1a) Fix bugs; Add unit tests - [`4d49708`](https://github.com/kvcache-ai/Mooncake/commit/4d49708dcb1c91f04a9c64ce9f421e7e4ceb10cc) Enhance unit tests - [`4bb1d0d`](https://github.com/kvcache-ai/Mooncake/commit/4bb1d0db1d3e81947409b23c57b25e8200f21ced) Enhance unit tests - [`a87e463`](https://github.com/kvcache-ai/Mooncake/commit/a87e4636781f91c76d705521b6e069bb0bb59eeb) revert unnecessary changes - [`c1d95e4`](https://github.com/kvcache-ai/Mooncake/commit/c1d95e46df986da019f4affc4f801a79b74026ef) Enhance unit test - [`b614f19`](https://github.com/kvcache-ai/Mooncake/commit/b614f19f5778ac22850730500dc6c1829a1b2f6b) Minor changes - [`acc5f10`](https://github.com/kvcache-ai/Mooncake/commit/acc5f1030eb5e9f54312b2cd20daa9196de91c4e) Update unit test - [`cbeb7f6`](https://github.com/kvcache-ai/Mooncake/commit/cbeb7f699c2a63a74292b06bb984ef53f23f9cdb) Avoid too many error log - [`5ae3729`](https://github.com/kvcache-ai/Mooncake/commit/5ae372974dcbbe999cdf591b3bd89a0633302fa9) Add comments ### 📊 Changes **7 files changed** (+1196 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/offset_allocator/offset_allocator.hpp` (+123 -4) ➕ `mooncake-store/include/serializer.h` (+377 -0) 📝 `mooncake-store/include/types.h` (+4 -0) 📝 `mooncake-store/tests/CMakeLists.txt` (+11 -0) 📝 `mooncake-store/tests/master_metrics_test.cpp` (+0 -4) 📝 `mooncake-store/tests/offset_allocator_test.cpp` (+508 -90) ➕ `mooncake-store/tests/serializer_test.cpp` (+173 -0) </details> ### 📄 Description This feature will be used for persisting master KV metadata. The serialize and deserialize methods of OffsetAllocator are implemented as templates; otherwise, offset_allocator.h would need to directly or indirectly include type.h, which would result in circular dependencies and compilation failure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:28 +00:00