[PR #763] [MERGED] refactor(store): remove garbage collection implementation #1804

New issue

Closed

opened 2026-10-29 21:30:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/763
Author: @xiaguan
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @xiaguan

Base: main ← Head: remove_gc

📝 Commits (3)

f2f9fd8 refactor(store): remove garbage collection implementation and related configurations
655154c fix(client-monitor): stop client monitor thread before joining in destructor
37c5cc9 feat(master-service): add eviction thread functionality

📊 Changes

12 files changed (+36 additions, -258 deletions)

View changed files

📝 doc/en/mooncake-store-preview.md (+1 -1)
📝 docs/source/design/mooncake-store-preview.md (+1 -1)
📝 docs/source/mooncake-store-api/python-binding.md (+1 -1)
📝 mooncake-store/conf/master.yaml (+0 -1)
📝 mooncake-store/include/master_config.h (+0 -18)
📝 mooncake-store/include/master_service.h (+8 -43)
📝 mooncake-store/src/master.cpp (+0 -9)
📝 mooncake-store/src/master_service.cpp (+16 -76)
📝 mooncake-store/tests/master_metrics_test.cpp (+0 -2)
📝 mooncake-store/tests/master_service_ssd_test.cpp (+1 -1)
📝 mooncake-store/tests/master_service_test.cpp (+7 -104)
📝 mooncake-wheel/tests/test_cli.py (+1 -1)

📄 Description

as title

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/763 **Author:** [@xiaguan](https://github.com/xiaguan) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@xiaguan](https://github.com/xiaguan) **Base:** `main` ← **Head:** `remove_gc` --- ### 📝 Commits (3) - [`f2f9fd8`](https://github.com/kvcache-ai/Mooncake/commit/f2f9fd803cf63d5397a58706327984447be117e8) refactor(store): remove garbage collection implementation and related configurations - [`655154c`](https://github.com/kvcache-ai/Mooncake/commit/655154c0582c5d86db1cdd3086d82fd33be82458) fix(client-monitor): stop client monitor thread before joining in destructor - [`37c5cc9`](https://github.com/kvcache-ai/Mooncake/commit/37c5cc939704f51cc7fa16c2346606b60c9aa6f6) feat(master-service): add eviction thread functionality ### 📊 Changes **12 files changed** (+36 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `doc/en/mooncake-store-preview.md` (+1 -1) 📝 `docs/source/design/mooncake-store-preview.md` (+1 -1) 📝 `docs/source/mooncake-store-api/python-binding.md` (+1 -1) 📝 `mooncake-store/conf/master.yaml` (+0 -1) 📝 `mooncake-store/include/master_config.h` (+0 -18) 📝 `mooncake-store/include/master_service.h` (+8 -43) 📝 `mooncake-store/src/master.cpp` (+0 -9) 📝 `mooncake-store/src/master_service.cpp` (+16 -76) 📝 `mooncake-store/tests/master_metrics_test.cpp` (+0 -2) 📝 `mooncake-store/tests/master_service_ssd_test.cpp` (+1 -1) 📝 `mooncake-store/tests/master_service_test.cpp` (+7 -104) 📝 `mooncake-wheel/tests/test_cli.py` (+1 -1) </details> ### 📄 Description as title --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:29 +00:00