[PR #765] [MERGED] Fix Handshake Daemon Initialization Order #1805

New issue

Closed

opened 2026-10-29 21:30:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/765
Author: @staryxchen
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/28/2025
Merged by: @stmatengss

Base: main ← Head: fix/callback

📝 Commits (1)

102ab41 fix(transfer): correct handshake daemon initialization order

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 mooncake-transfer-engine/src/transfer_metadata.cpp (+5 -5)

📄 Description

Summary

Fixes incorrect initialization sequence in startHandshakeDaemon() by moving the daemon start call after callback registrations.

Changes

Before: Daemon started before registering callbacks
After: Callbacks registered first, then daemon started

Why

The original order could cause race conditions where the daemon becomes active before callbacks are properly set up, potentially leading to missed or improperly handled handshake events.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/765 **Author:** [@staryxchen](https://github.com/staryxchen) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/28/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `fix/callback` --- ### 📝 Commits (1) - [`102ab41`](https://github.com/kvcache-ai/Mooncake/commit/102ab41c216de5ebccc9f7a00df641e184e2229f) fix(transfer): correct handshake daemon initialization order ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/src/transfer_metadata.cpp` (+5 -5) </details> ### 📄 Description # Summary Fixes incorrect initialization sequence in `startHandshakeDaemon()` by moving the daemon start call after callback registrations. # Changes - Before: Daemon started before registering callbacks - After: Callbacks registered first, then daemon started # Why The original order could cause race conditions where the daemon becomes active before callbacks are properly set up, potentially leading to missed or improperly handled handshake events. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:30 +00:00