[PR #768] [MERGED] [TE][EndpointStore]: Fix hand_ assignment after evict #1809

New issue

Closed

opened 2026-10-29 21:30:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/768
Author: @lizhemingi
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/25/2025
Merged by: @alogfans

Base: main ← Head: fix-hand-after-evict

📝 Commits (1)

2caf537 [TE][EndpointStore]: Fix hand_ assignment after evict

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 mooncake-transfer-engine/src/transport/rdma_transport/endpoint_store.cpp (+4 -4)

📄 Description

Suppose we set the capacity of endpoint store to 1, after first time eviction, hand_ will be at an illegal address and get segment fault in second time eviction.

And I think we can still do a log when endpoints are evicted, it may be helpful for debug.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/768 **Author:** [@lizhemingi](https://github.com/lizhemingi) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/25/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `fix-hand-after-evict` --- ### 📝 Commits (1) - [`2caf537`](https://github.com/kvcache-ai/Mooncake/commit/2caf537c2ee6ab564984f38f77acb2d56b50b254) [TE][EndpointStore]: Fix hand_ assignment after evict ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/src/transport/rdma_transport/endpoint_store.cpp` (+4 -4) </details> ### 📄 Description Suppose we set the capacity of endpoint store to 1, after first time eviction, hand_ will be at an illegal address and get segment fault in second time eviction. And I think we can still do a log when endpoints are evicted, it may be helpful for debug. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:31 +00:00