[PR #779] [MERGED] [TE] Fix notifs problems in C wrapper #1816

New issue

Closed

opened 2026-10-29 21:30:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/779
Author: @alogfans
Created: 8/25/2025
Status: ✅ Merged
Merged: 8/28/2025
Merged by: @ShangmingCai

Base: main ← Head: fix-notify-cpp-interface

📝 Commits (4)

1b911ac [TE] Fix notifs problems in C wrapper
eae1078 update alloc function
554a64d Fix memory alloc issue
07ab008 format

📊 Changes

2 files changed (+38 additions, -12 deletions)

View changed files

📝 mooncake-transfer-engine/include/transfer_engine_c.h (+2 -0)
📝 mooncake-transfer-engine/src/transfer_engine_c.cpp (+36 -12)

📄 Description

Trying to fix problems in #769 #770.

NB. After merging this PR, the NIXL plugin should use freeNotifsMsgBuf instead of free in the following code snipple. @haobayuxi

github.com/ai-dynamo/nixl@787dd7b5d0/src/plugins/mooncake/mooncake_backend.cpp (L328)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/779 **Author:** [@alogfans](https://github.com/alogfans) **Created:** 8/25/2025 **Status:** ✅ Merged **Merged:** 8/28/2025 **Merged by:** [@ShangmingCai](https://github.com/ShangmingCai) **Base:** `main` ← **Head:** `fix-notify-cpp-interface` --- ### 📝 Commits (4) - [`1b911ac`](https://github.com/kvcache-ai/Mooncake/commit/1b911acf1a048023a9236d0fe7b2d564224c1eb4) [TE] Fix notifs problems in C wrapper - [`eae1078`](https://github.com/kvcache-ai/Mooncake/commit/eae107891ba6e27f09265cdc98b480feb6f2d807) update alloc function - [`554a64d`](https://github.com/kvcache-ai/Mooncake/commit/554a64d0a80a7e9500ab733f94c68894ad1c14ba) Fix memory alloc issue - [`07ab008`](https://github.com/kvcache-ai/Mooncake/commit/07ab008d85227ffd5c4c5bcb25debeb7fa7d37c7) format ### 📊 Changes **2 files changed** (+38 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/include/transfer_engine_c.h` (+2 -0) 📝 `mooncake-transfer-engine/src/transfer_engine_c.cpp` (+36 -12) </details> ### 📄 Description Trying to fix problems in #769 #770. NB. After merging this PR, the NIXL plugin should use `freeNotifsMsgBuf` instead of `free` in the following code snipple. @haobayuxi https://github.com/ai-dynamo/nixl/blob/787dd7b5d074d0ba0755e6c50cc21fdb330114c3/src/plugins/mooncake/mooncake_backend.cpp#L328 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:35 +00:00