[PR #787] [CLOSED] Fixnixlbench #1822

New issue

Closed

opened 2026-10-29 21:30:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/787
Author: @haobayuxi
Created: 8/28/2025
Status: ❌ Closed

Base: main ← Head: fixnixlbench

📝 Commits (6)

cc2b6c5 modify cachelib with slab reallocated
b8e3aa6 Merge branch 'kvcache-ai:main' into main
bfff924 Merge branch 'kvcache-ai:main' into main
60d4cb5 Merge branch 'kvcache-ai:main' into main
b658853 Merge branch 'kvcache-ai:main' into main
bdf9dd0 fix nixl bench bug

📊 Changes

7 files changed (+795 additions, -555 deletions)

View changed files

📝 mooncake-store/include/cachelib_memory_allocator/AllocationClass.h (+157 -77)
📝 mooncake-store/include/cachelib_memory_allocator/MemoryPool.h (+311 -313)
📝 mooncake-store/src/cachelib_memory_allocator/AllocationClass.cpp (+213 -138)
📝 mooncake-store/src/cachelib_memory_allocator/MemoryAllocator.cpp (+4 -6)
📝 mooncake-store/src/cachelib_memory_allocator/MemoryPool.cpp (+17 -15)
📝 mooncake-store/tests/master_service_test.cpp (+91 -2)
📝 mooncake-transfer-engine/src/transfer_engine_c.cpp (+2 -4)

📄 Description

fix the nixl bench bug. Using strncpy to copy the string without handling the boundary. Occasionally, incorrect characters appear at the end. Causing errors in string matching for nixl. So use strcpy instead. The size of the char[] is malloc as the string size + 1. So using strcpy is fine.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/787 **Author:** [@haobayuxi](https://github.com/haobayuxi) **Created:** 8/28/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fixnixlbench` --- ### 📝 Commits (6) - [`cc2b6c5`](https://github.com/kvcache-ai/Mooncake/commit/cc2b6c5c5383a89a328f688fc590ee86177daf4a) modify cachelib with slab reallocated - [`b8e3aa6`](https://github.com/kvcache-ai/Mooncake/commit/b8e3aa673eacfe5aebff6611aed04df656f6b13b) Merge branch 'kvcache-ai:main' into main - [`bfff924`](https://github.com/kvcache-ai/Mooncake/commit/bfff924381a4294b3c0625db49242f3b993b39de) Merge branch 'kvcache-ai:main' into main - [`60d4cb5`](https://github.com/kvcache-ai/Mooncake/commit/60d4cb5ccbdbb25df2beb7751a19ec889bf14ffc) Merge branch 'kvcache-ai:main' into main - [`b658853`](https://github.com/kvcache-ai/Mooncake/commit/b658853a078cf67e9deda02c9ff37334bfb681d5) Merge branch 'kvcache-ai:main' into main - [`bdf9dd0`](https://github.com/kvcache-ai/Mooncake/commit/bdf9dd096fddf3d6d1dc439abfb6db018a7380fc) fix nixl bench bug ### 📊 Changes **7 files changed** (+795 additions, -555 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/cachelib_memory_allocator/AllocationClass.h` (+157 -77) 📝 `mooncake-store/include/cachelib_memory_allocator/MemoryPool.h` (+311 -313) 📝 `mooncake-store/src/cachelib_memory_allocator/AllocationClass.cpp` (+213 -138) 📝 `mooncake-store/src/cachelib_memory_allocator/MemoryAllocator.cpp` (+4 -6) 📝 `mooncake-store/src/cachelib_memory_allocator/MemoryPool.cpp` (+17 -15) 📝 `mooncake-store/tests/master_service_test.cpp` (+91 -2) 📝 `mooncake-transfer-engine/src/transfer_engine_c.cpp` (+2 -4) </details> ### 📄 Description fix the nixl bench bug. Using strncpy to copy the string without handling the boundary. Occasionally, incorrect characters appear at the end. Causing errors in string matching for nixl. So use strcpy instead. The size of the char[] is malloc as the string size + 1. So using strcpy is fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:37 +00:00