[PR #839] [MERGED] [Build] Install Python Files Patch #1860

New issue

Closed

opened 2026-10-29 21:30:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:30:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/839
Author: @ykwd
Created: 9/15/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @ykwd

Base: main ← Head: build/install_python_files

📝 Commits (5)

64fb8ad Install python files
a5e051c Remove test message
a619bc4 patch
600c59e Merge main
739b6c0 Merge main

📊 Changes

1 file changed (+10 additions, -4 deletions)

View changed files

📝 mooncake-integration/CMakeLists.txt (+10 -4)

📄 Description

This is a patch for this pr: https://github.com/kvcache-ai/Mooncake/pull/836

This PR makes the following changes:

Only install Python files that depend on Store when the WITH_STORE flag is enabled.
Update the permissions of the site-packages/mooncake directory from 766 to 767 (i.e., chmod o+x) so that non-root users can access the files inside. With 766, since the files are installed via sudo make install, regular users cannot read or execute them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/839 **Author:** [@ykwd](https://github.com/ykwd) **Created:** 9/15/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@ykwd](https://github.com/ykwd) **Base:** `main` ← **Head:** `build/install_python_files` --- ### 📝 Commits (5) - [`64fb8ad`](https://github.com/kvcache-ai/Mooncake/commit/64fb8ad7e6e065800952c831597df2cac8a02105) Install python files - [`a5e051c`](https://github.com/kvcache-ai/Mooncake/commit/a5e051cc44838f4085865086fcd1b0628c39ee06) Remove test message - [`a619bc4`](https://github.com/kvcache-ai/Mooncake/commit/a619bc469f5e62deb2c246282832f7efb1739c07) patch - [`600c59e`](https://github.com/kvcache-ai/Mooncake/commit/600c59ee8c4bc6456eda26e9ee3c8a3b226f0c1b) Merge main - [`739b6c0`](https://github.com/kvcache-ai/Mooncake/commit/739b6c09eda2f565a9d1501f1a535c3ccd335638) Merge main ### 📊 Changes **1 file changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-integration/CMakeLists.txt` (+10 -4) </details> ### 📄 Description This is a patch for this pr: https://github.com/kvcache-ai/Mooncake/pull/836 This PR makes the following changes: * Only install Python files that depend on **Store** when the `WITH_STORE` flag is enabled. * Update the permissions of the `site-packages/mooncake` directory from `766` to `767` (i.e., `chmod o+x`) so that non-root users can access the files inside. With `766`, since the files are installed via `sudo make install`, regular users cannot read or execute them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:30:56 +00:00