[GH-ISSUE #571] [bug] BatchIsExist and BatchIsPut may have errors. #190

Closed
opened 2026-10-29 21:10:41 +00:00 by bsakaguchi · 2 comments
Owner

Originally created by @jeremyzhang866 on GitHub (Jun 30, 2025).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/571

when you test client_integration_test.cpp
ASSERT_EQ(test_client_->BatchIsExist(keys, exist_results), ErrorCode::OK);

[ OK ] ClientIntegrationTest.BatchPutGetOperations (24 ms)
[ RUN ] ClientIntegrationTest.BatchIsExistOperations

but log show that: means that BatchIsExist is error?!
I0701 00:37:27.737293 272358 scoped_vlog_timer.h:75] MasterClient::BatchExistKey response: {"exist_responses":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704]}, latency=820us

Originally created by @jeremyzhang866 on GitHub (Jun 30, 2025). Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/571 when you test client_integration_test.cpp `ASSERT_EQ(test_client_->BatchIsExist(keys, exist_results), ErrorCode::OK);` [ OK ] ClientIntegrationTest.BatchPutGetOperations (24 ms) [ RUN ] ClientIntegrationTest.BatchIsExistOperations but log show that: means that BatchIsExist is error?! `I0701 00:37:27.737293 272358 scoped_vlog_timer.h:75] MasterClient::BatchExistKey response: {"exist_responses":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704,-704]}, latency=820us`
Author
Owner

@jeremyzhang866 commented on GitHub (Jun 30, 2025):

@xiaguan PTAL. THANKS

<!-- gh-comment-id:3019916268 --> @jeremyzhang866 commented on GitHub (Jun 30, 2025): @xiaguan PTAL. THANKS
Author
Owner

@xiaguan commented on GitHub (Jul 1, 2025):

Before PR #562, we did use OBJECT_NOT_FOUND as the error code in Exist. After PR #562, that issue should no longer happen. The test is intentionally checking cases where some objects exist and some don’t, so the logs look as expected.

<!-- gh-comment-id:3021503144 --> @xiaguan commented on GitHub (Jul 1, 2025): Before PR #562, we did use `OBJECT_NOT_FOUND` as the error code in Exist. After PR #562, that issue should no longer happen. The test is intentionally checking cases where some objects exist and some don’t, so the logs look as expected.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kvcache-ai/Mooncake#190
No description provided.